[PATCH 3/3] drm/i915: Disable all planes for load detection, v2.
maarten.lankhorst at linux.intel.com
Thu Dec 21 09:58:59 UTC 2017
Op 20-12-17 om 11:28 schreef Daniel Vetter:
> On Wed, Dec 20, 2017 at 10:35:45AM +0100, Maarten Lankhorst wrote:
>> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>> We don't need any active planes during load detection, so just disable
>> them all. This saves us from having to come up with a suitable
>> framebuffer. And we also avoid leaving sprite/cursor planes on and
>> potentially presenting them at a peculiar location during the load
>> Changes since v1 (Maarten):
>> - Add missing call to add_all_affected_planes.
>> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102707
> Less code, I like. And I think we have enough load-detect machines (+ plus
> the nasty igt to do it anywhere we still have native vga) to have
> reasonable ensurance it actually works.
> But maybe let's soak this in -next first for a while, then cherry-pick
> over after a few weeks once it's solid.
> With the missing Fixes: line added.
> Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
Pushed, didn't add fixes since it's an ancient bug, for a piece of code that changed a lot.
Since in most cases the fbcon fb will be leaked, the impact is just a warning and not even
a real leak. :)
Thanks for review,
More information about the dri-devel