[PATCH 2/2] drm: Rely on mode_config data for fb_helper initialization

Eric Anholt eric at anholt.net
Wed Feb 1 20:50:48 UTC 2017


Gabriel Krisman Bertazi <krisman at collabora.co.uk> writes:

> Instead of receiving the num_crts as a parameter, we can read it
> directly from the mode_config structure.  I audited the drivers that
> invoke this helper and I believe all of them (but one, see below)
> initialize the mode_config struct accordingly, prior to calling the
> fb_helper.

This is a nice cleanup!  It always felt silly to be passing in my
mode_config's members to the fbdev setup.  Could we do the same for
num_connector?

I've verified that all the drivers either init their CRTCs or have
already looked at mode_config.num_crtcs before the fbdev init call, so
this is:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20170201/bfdf0469/attachment.sig>


More information about the dri-devel mailing list