[PATCH 2/2] drm: Rely on mode_config data for fb_helper initialization

Daniel Vetter daniel at ffwll.ch
Thu Feb 2 09:09:42 UTC 2017


On Wed, Feb 01, 2017 at 12:50:48PM -0800, Eric Anholt wrote:
> Gabriel Krisman Bertazi <krisman at collabora.co.uk> writes:
> 
> > Instead of receiving the num_crts as a parameter, we can read it
> > directly from the mode_config structure.  I audited the drivers that
> > invoke this helper and I believe all of them (but one, see below)
> > initialize the mode_config struct accordingly, prior to calling the
> > fb_helper.
> 
> This is a nice cleanup!  It always felt silly to be passing in my
> mode_config's members to the fbdev setup.  Could we do the same for
> num_connector?
> 
> I've verified that all the drivers either init their CRTCs or have
> already looked at mode_config.num_crtcs before the fbdev init call, so
> this is:
> 
> Reviewed-by: Eric Anholt <eric at anholt.net>

Yeah, nice patch but doesn't apply now that Dave has pulled in a bunch of
driver pull requests :( Can you pls regen the cocci, but pls keep Eric's
r-b so I don't have to go hunting for it.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list