[PATCH 1/2] drm: sti: Prevent race on fbdev initialization

Gabriel Krisman Bertazi krisman at collabora.co.uk
Thu Feb 2 15:47:10 UTC 2017


Gabriel Krisman Bertazi <krisman at collabora.co.uk> writes:

> Scheduling the output_poll_work before calling bind_all to create the
> crtcs can race the fbdev initialization with the components
> initialization (i.e. crtc initialization).  One side effect is that we
> may call drm_fbdev_cma_init with a zeroed num_crtc value, crashing the
> fbdev allocation.

This is no longer true after

8953e9ee0ce5 ("drm/sti: create fbdev at binding") # drm-misc-next.

That commit moved the fbdev initialization out of the output_poll_work,
forcing it to happen after creating crtcs, so this patch is no longer
necessary.  I'll resend a v2 of the series without it.

-- 
Gabriel Krisman Bertazi


More information about the dri-devel mailing list