[PATCH 3/9] gpu: ipu-v3: add driver for Prefetch Resolve Engine
Philipp Zabel
p.zabel at pengutronix.de
Mon Mar 6 08:42:38 UTC 2017
On Fri, 2017-03-03 at 19:25 +0100, Lucas Stach wrote:
[...]
> > > +int ipu_pre_get(struct ipu_pre *pre)
> > > +{
> > > + u32 val;
> > > +
> > > + if (pre->in_use)
> > > + return -EBUSY;
> >
> > This could race for in_use ...
>
> All the PRE/PRG configuration functions are thread unsafe, with the
> premise that they are only used during an atomic commit, [...]
Oh, okay. It would be nice to point this out in a comment.
regards
Philipp
More information about the dri-devel
mailing list