[PATCH 13/16] drm/omap: use u32 instead of enum omap_color_mode
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Wed May 24 10:28:55 UTC 2017
Hi Tomi,
Thank you for the patch.
On Thursday 04 May 2017 13:23:29 Tomi Valkeinen wrote:
> In this step we drop 'enum omap_color_mode', and use u32 instead.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ti.com>
I believe this should go before 12/16, otherwise you end up temporarily
storing DRM_FORMAT_* values in enum omap_color_mode variables.
Apart from that,
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> drivers/gpu/drm/omapdrm/dss/dispc.c | 48 +++++++++++++-------------
> drivers/gpu/drm/omapdrm/dss/dss_features.c | 16 +++++-----
> drivers/gpu/drm/omapdrm/dss/dss_features.h | 4 +--
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 10 ++-----
> drivers/gpu/drm/omapdrm/omap_drv.h | 2 +-
> drivers/gpu/drm/omapdrm/omap_fb.c | 8 ++---
> 6 files changed, 42 insertions(+), 46 deletions(-)
--
Regards,
Laurent Pinchart
More information about the dri-devel
mailing list