[PATCH 13/16] drm/omap: use u32 instead of enum omap_color_mode

Tomi Valkeinen tomi.valkeinen at ti.com
Wed May 24 10:37:48 UTC 2017



On 24/05/17 13:28, Laurent Pinchart wrote:
> Hi Tomi,
> 
> Thank you for the patch.
> 
> On Thursday 04 May 2017 13:23:29 Tomi Valkeinen wrote:
>> In this step we drop 'enum omap_color_mode', and use u32 instead.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ti.com>
> 
> I believe this should go before 12/16, otherwise you end up temporarily 
> storing DRM_FORMAT_* values in enum omap_color_mode variables.

That's on purpose, I mention it in the previous patch. Do you see a
problem with it?

If I change the order, then I'd be going back and forth with u32 and
enum omap_color_mode.

But I could squash this and 12 together. That's perhaps the technically
most correct option, but I wanted to split the changes into a bit
smaller pieces.

 Tomi



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20170524/796a876f/attachment.sig>


More information about the dri-devel mailing list