[PATCH v4 08/11] drm/arm/hdlcd: Use drm_gem_cma_print_info()

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sat Nov 4 07:55:27 UTC 2017


Hi Noralf,

Thank you for the patch.

On Monday, 30 October 2017 18:29:42 EET Noralf Trønnes wrote:
> There is a new core debugfs file that prints fb/gem info:
> <debugfs>/dri/<n>/framebuffer
> 
> Use drm_gem_cma_print_info() to provide info to that output instead
> of using drm_fb_cma_debugfs_show().
> 
> Cc: Liviu Dudau <liviu.dudau at arm.com>
> Cc: Brian Starkey <brian.starkey at arm.com>
> Signed-off-by: Noralf Trønnes <noralf at tronnes.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  drivers/gpu/drm/arm/hdlcd_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c
> b/drivers/gpu/drm/arm/hdlcd_drv.c index 764d0c83710c..59b21bdc0c30 100644
> --- a/drivers/gpu/drm/arm/hdlcd_drv.c
> +++ b/drivers/gpu/drm/arm/hdlcd_drv.c
> @@ -230,7 +230,6 @@ static int hdlcd_show_pxlclock(struct seq_file *m, void
> *arg) static struct drm_info_list hdlcd_debugfs_list[] = {
>  	{ "interrupt_count", hdlcd_show_underrun_count, 0 },
>  	{ "clocks", hdlcd_show_pxlclock, 0 },
> -	{ "fb", drm_fb_cma_debugfs_show, 0 },
>  };
> 
>  static int hdlcd_debugfs_init(struct drm_minor *minor)
> @@ -252,6 +251,7 @@ static struct drm_driver hdlcd_driver = {
>  	.irq_postinstall = hdlcd_irq_postinstall,
>  	.irq_uninstall = hdlcd_irq_uninstall,
>  	.gem_free_object_unlocked = drm_gem_cma_free_object,
> +	.gem_print_info = drm_gem_cma_print_info,
>  	.gem_vm_ops = &drm_gem_cma_vm_ops,
>  	.dumb_create = drm_gem_cma_dumb_create,
>  	.prime_handle_to_fd = drm_gem_prime_handle_to_fd,


-- 
Regards,

Laurent Pinchart



More information about the dri-devel mailing list