[PATCH v4 09/11] drm/tilcdc: Use drm_gem_cma_print_info()

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sat Nov 4 07:56:04 UTC 2017


Hi Noralf,

Thank you for the patch.

On Monday, 30 October 2017 18:29:43 EET Noralf Trønnes wrote:
> There is a new core debugfs file that prints fb/gem info:
> <debugfs>/dri/<n>/framebuffer
> 
> Use drm_gem_cma_print_info() to provide info to that output instead
> of using drm_fb_cma_debugfs_show().
> 
> Cc: Jyri Sarha <jsarha at ti.com>
> Cc: Tomi Valkeinen <tomi.valkeinen at ti.com>
> Signed-off-by: Noralf Trønnes <noralf at tronnes.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index 72ce063aa0d8..bc4feb3a84b9
> 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -507,7 +507,6 @@ static int tilcdc_mm_show(struct seq_file *m, void *arg)
> static struct drm_info_list tilcdc_debugfs_list[] = {
>  		{ "regs", tilcdc_regs_show, 0 },
>  		{ "mm",   tilcdc_mm_show,   0 },
> -		{ "fb",   drm_fb_cma_debugfs_show, 0 },
>  };
> 
>  static int tilcdc_debugfs_init(struct drm_minor *minor)
> @@ -541,6 +540,7 @@ static struct drm_driver tilcdc_driver = {
>  	.lastclose          = tilcdc_lastclose,
>  	.irq_handler        = tilcdc_irq,
>  	.gem_free_object_unlocked = drm_gem_cma_free_object,
> +	.gem_print_info     = drm_gem_cma_print_info,
>  	.gem_vm_ops         = &drm_gem_cma_vm_ops,
>  	.dumb_create        = drm_gem_cma_dumb_create,


-- 
Regards,

Laurent Pinchart



More information about the dri-devel mailing list