[PATCH v3] drm: drm_vblank_cleanup: WARN when refcount > 0

PrasannaKumar Muralidharan prasannatsmkumar at gmail.com
Wed Oct 25 16:24:15 UTC 2017


Warn when refcount > 0 in drm_vblank_cleanup.

Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar at gmail.com>
---
Changes in v3:
* Dropped i915 patch that is used for testing this.

No changes in v2.

 drivers/gpu/drm/drm_vblank.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
index 70f2b95..3e61aeb 100644
--- a/drivers/gpu/drm/drm_vblank.c
+++ b/drivers/gpu/drm/drm_vblank.c
@@ -405,6 +405,8 @@ void drm_vblank_cleanup(struct drm_device *dev)
 	for (pipe = 0; pipe < dev->num_crtcs; pipe++) {
 		struct drm_vblank_crtc *vblank = &dev->vblank[pipe];
 
+		WARN_ON(atomic_read(&vblank->refcount) > 0);
+
 		WARN_ON(READ_ONCE(vblank->enabled) &&
 			drm_core_check_feature(dev, DRIVER_MODESET));
 
-- 
2.10.0



More information about the dri-devel mailing list