[PATCH v2 1/2] drm: content-type property for HDMI connector
Jani Nikula
jani.nikula at linux.intel.com
Wed Apr 18 11:50:11 UTC 2018
On Wed, 18 Apr 2018, StanLis <stanislav.lisovskiy at intel.com> wrote:
> +static const struct drm_prop_enum_list drm_content_type_enum_list[] = {
> + { DRM_MODE_CONTENT_TYPE_GRAPHICS, "GRAPHICS" },
> + { DRM_MODE_CONTENT_TYPE_PHOTO, "PHOTO" },
> + { DRM_MODE_CONTENT_TYPE_CINEMA, "CINEMA" },
> + { DRM_MODE_CONTENT_TYPE_GAME, "GAME" },
> +};
> +
Values all caps...
> +int drm_mode_create_content_type_property(struct drm_device *dev)
> +{
> + if (dev->mode_config.content_type_property)
> + return 0;
> +
> + dev->mode_config.content_type_property =
> + drm_property_create_enum(dev, 0, "content type",
> + drm_content_type_enum_list,
> + ARRAY_SIZE(drm_content_type_enum_list));
...and property name lower case with a space.
Can we please have a little more consistency at least within properties?
Overall it's a huge mess already, but it doesn't help to add to the
mess.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
More information about the dri-devel
mailing list