[PATCH v2 1/2] drm: content-type property for HDMI connector

[Lisovskiy, Stanislav]

Totally agree about caps, thanks for spotting.
________________________________________
From: Jani Nikula [jani.nikula at linux.intel.com]
Sent: Wednesday, April 18, 2018 2:50 PM
To: Lisovskiy, Stanislav; dri-devel at lists.freedesktop.org
Cc: intel-gfx at linux.intel.com
Subject: Re: [PATCH v2 1/2] drm: content-type property for HDMI connector

On Wed, 18 Apr 2018, StanLis <stanislav.lisovskiy at intel.com> wrote:
> +static const struct drm_prop_enum_list drm_content_type_enum_list[] = {
> +     { DRM_MODE_CONTENT_TYPE_GRAPHICS, "GRAPHICS" },
> +     { DRM_MODE_CONTENT_TYPE_PHOTO, "PHOTO" },
> +     { DRM_MODE_CONTENT_TYPE_CINEMA, "CINEMA" },
> +     { DRM_MODE_CONTENT_TYPE_GAME, "GAME" },
> +};
> +

Values all caps...

> +int drm_mode_create_content_type_property(struct drm_device *dev)
> +{
> +     if (dev->mode_config.content_type_property)
> +             return 0;
> +
> +     dev->mode_config.content_type_property =
> +             drm_property_create_enum(dev, 0, "content type",
> +                             drm_content_type_enum_list,
> +                             ARRAY_SIZE(drm_content_type_enum_list));

...and property name lower case with a space.

Can we please have a little more consistency at least within properties?
Overall it's a huge mess already, but it doesn't help to add to the
mess.

BR,
Jani.


--
Jani Nikula, Intel Open Source Technology Center