[PATCH] drm/scheduler: Remove entity->rq NULL check

Christian König ckoenig.leichtzumerken at gmail.com
Mon Aug 6 14:13:19 UTC 2018


Ping. Any objections to that?

Christian.

Am 03.08.2018 um 13:08 schrieb Christian König:
> That is superflous now.
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>   drivers/gpu/drm/scheduler/gpu_scheduler.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c
> index 85908c7f913e..65078dd3c82c 100644
> --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c
> +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c
> @@ -590,11 +590,6 @@ void drm_sched_entity_push_job(struct drm_sched_job *sched_job,
>   	if (first) {
>   		/* Add the entity to the run queue */
>   		spin_lock(&entity->rq_lock);
> -		if (!entity->rq) {
> -			DRM_ERROR("Trying to push to a killed entity\n");
> -			spin_unlock(&entity->rq_lock);
> -			return;
> -		}
>   		drm_sched_rq_add_entity(entity->rq, entity);
>   		spin_unlock(&entity->rq_lock);
>   		drm_sched_wakeup(entity->rq->sched);



More information about the dri-devel mailing list