[PATCH 5/5] drm/doc: Use new substruct support

Daniel Vetter daniel at ffwll.ch
Tue Feb 20 11:10:35 UTC 2018


On Tue, Feb 20, 2018 at 10:49:52AM +0100, Thierry Reding wrote:
> On Mon, Feb 19, 2018 at 11:53:56PM +0100, Daniel Vetter wrote:
> > Note: This is untested because the new stuff hasn't landed in upstream
> > yet. But it should work.

Ok Jani put the patch into topic/core-for-CI temporarily, so I could test.
It works.

> > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> > ---
> >  include/drm/drm_vblank.h | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> 
> I couldn't find a reference to the new stuff, so maybe this was already
> discussed, but wouldn't it be possible for the parser to figure out the
> substruct by itself? That way the event. prefix could be avoided.

https://lkml.org/lkml/2018/2/16/339

Jon said he pulled it all in already, I guess this way was simplest, the
actual fix is a one-liner:

https://lkml.org/lkml/2018/2/16/344

The reason for this is likely that you'll end up with name clashes
everywhere if you don't insist on the fully qualified name.

I merged the other patches meanwhile, thanks a lot for your review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list