[PATCH 5/5] drm/doc: Use new substruct support
Thierry Reding
thierry.reding at gmail.com
Tue Feb 20 11:22:18 UTC 2018
On Tue, Feb 20, 2018 at 12:10:35PM +0100, Daniel Vetter wrote:
> On Tue, Feb 20, 2018 at 10:49:52AM +0100, Thierry Reding wrote:
> > On Mon, Feb 19, 2018 at 11:53:56PM +0100, Daniel Vetter wrote:
> > > Note: This is untested because the new stuff hasn't landed in upstream
> > > yet. But it should work.
>
> Ok Jani put the patch into topic/core-for-CI temporarily, so I could test.
> It works.
>
> > > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> > > ---
> > > include/drm/drm_vblank.h | 16 ++++++++++++++++
> > > 1 file changed, 16 insertions(+)
> >
> > I couldn't find a reference to the new stuff, so maybe this was already
> > discussed, but wouldn't it be possible for the parser to figure out the
> > substruct by itself? That way the event. prefix could be avoided.
>
> https://lkml.org/lkml/2018/2/16/339
>
> Jon said he pulled it all in already, I guess this way was simplest, the
> actual fix is a one-liner:
>
> https://lkml.org/lkml/2018/2/16/344
>
> The reason for this is likely that you'll end up with name clashes
> everywhere if you don't insist on the fully qualified name.
Thanks for the pointers. I would've thought that the parser could simply
stick the prefix onto the name itself to make it fully qualified and
thereby avoid any name clashes.
But looking at the patches and the parser a little, this will have to do
for now:
Reviewed-by: Thierry Reding <treding at nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180220/f773cb1e/attachment.sig>
More information about the dri-devel
mailing list