[RFC PATCH v3 0/2] drm: Add generic colorkey plane properties

Dmitry Osipenko digetx at gmail.com
Sun Jun 3 22:00:57 UTC 2018


Hello,

In this version I've reduced color keying modes and properties to a bare
minimum because considering several modes and properties at once might take
quite a lot of effort due to a variety of HW capabilities. This allows us to
start easy with the generic colorkey properties support.

For the starter let's implement probably the most common (and simple) color
keying mode - the "green screen" (or "chroma key") mode. More advanced modes
and features could be implemented later on by as needed basis.

Following Ville's Syrjälä review comments to v2, the color key value is now
given in ARGB16161616 format. Drivers have to convert this 16bpc format into
internal color key value representation themselves. This works well for cases
where conversion is done to a non-planar integer formats, but I'm not sure how
drivers are supposed to cope with cases where conversion involves churning with
fixed point math / floating point representation. Comments are welcome.

v2: https://lists.freedesktop.org/archives/dri-devel/2018-May/178408.html
v1: https://lists.freedesktop.org/archives/dri-devel/2017-December/160510.html

Dmitry Osipenko (1):
  drm/tegra: plane: Implement generic colorkey property for older
    Tegra's

Laurent Pinchart (1):
  drm: Add generic colorkey properties for DRM planes

 drivers/gpu/drm/drm_atomic.c  |  12 ++++
 drivers/gpu/drm/drm_blend.c   |  99 +++++++++++++++++++++++++++++++++
 drivers/gpu/drm/tegra/dc.c    |  25 +++++++++
 drivers/gpu/drm/tegra/dc.h    |   7 +++
 drivers/gpu/drm/tegra/plane.c | 102 ++++++++++++++++++++++++++++++++++
 include/drm/drm_blend.h       |   3 +
 include/drm/drm_plane.h       |  53 ++++++++++++++++++
 7 files changed, 301 insertions(+)

-- 
2.17.0



More information about the dri-devel mailing list