[Bug 107012] [PATCH] Radeon SI driver not architecture safe, crashes on ppc64[el]

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107012

--- Comment #1 from Simon McVittie <smcv at collabora.com> ---
Comment on attachment 140294
  --> https://bugs.freedesktop.org/attachment.cgi?id=140294
Fix crashes

Review of attachment 140294:
-----------------------------------------------------------------

::: src/gallium/drivers/radeonsi/si_shader.h
@@ +507,4 @@
>  		unsigned	ancillary_vgpr_index:5;
>  		unsigned	wqm:1;
>  		char		color_attr_index[2];
> +		signed		color_interp_vgpr_index[2]; /* -1 == constant */

Shouldn't this be a signed char, to make the size of the struct the same on all
architectures?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180623/bbc0b2d3/attachment.html>