[Bug 106928] When starting a match Rocket League crashes on "Go"

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Jun 29 20:54:57 UTC 2018


https://bugs.freedesktop.org/show_bug.cgi?id=106928

--- Comment #17 from Roland Scheidegger <sroland at vmware.com> ---
(In reply to ubizjak from comment #15)
> (In reply to Dave Airlie from comment #14)
> > I think Roland's first patch is correct, just call fold_alu_op2 if we get
> > back 2 sources from fold_assoc. return true is for when we've finished all
> > folding on that instruction, so I don't think that's correct without calling
> > fold_alu_op2
> 
> LGTM then (it also fixes the failure for me), but can we please drop the
> "else" from the patch, it is really confusing.

Sure that can be done. (I was actually also wondering if the test for
n.src.size() < 3 at the beginning of the function is actually necessary, are we
really supposed to have already fewer sources when this is called? But I
couldn't quite answer that. This code is a bit confusing to me.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180629/8fe3885b/attachment.html>


More information about the dri-devel mailing list