[radeon-alex:drm-next-4.18-wip 44/78] drivers/gpu/drm/amd/amdgpu/soc15.c:680:3-24: duplicated argument to & or | (fwd)

Quan, Evan Evan.Quan at amd.com
Mon May 28 01:26:53 UTC 2018


Thanks Julia.


It's a typo. And a patch had been sent out to fix it.


Regards,

Evan

________________________________
From: Julia Lawall <julia.lawall at lip6.fr>
Sent: Saturday, May 19, 2018 4:50:04 AM
To: Quan, Evan
Cc: Deucher, Alexander; dri-devel at lists.freedesktop.org; kbuild-all at 01.org; Koenig, Christian; Huang, Ray
Subject: [radeon-alex:drm-next-4.18-wip 44/78] drivers/gpu/drm/amd/amdgpu/soc15.c:680:3-24: duplicated argument to & or | (fwd)

Lines 680 and 682 contain the same constant.

julia

---------- Forwarded message ----------
Date: Sat, 19 May 2018 04:22:09 +0800
From: kbuild test robot <lkp at intel.com>
To: kbuild at 01.org
Cc: Julia Lawall <julia.lawall at lip6.fr>
Subject: [radeon-alex:drm-next-4.18-wip 44/78]
    drivers/gpu/drm/amd/amdgpu/soc15.c:680:3-24: duplicated argument to & or |

CC: kbuild-all at 01.org
CC: dri-devel at lists.freedesktop.org
TO: Evan Quan <evan.quan at amd.com>
CC: Alex Deucher <alexander.deucher at amd.com>
CC: "Christian K├Ânig" <christian.koenig at amd.com>
CC: Huang Rui <ray.huang at amd.com>

tree:   git://people.freedesktop.org/~agd5f/linux.git drm-next-4.18-wip
head:   aa1bce17d841a362d40da940487e13affe4c7b3b
commit: 27eab5ad57b2da7803bb3e5d61c666b52b57d6f6 [44/78] drm/amd/powerplay: update vega20 cg flags
:::::: branch date: 26 hours ago
:::::: commit date: 29 hours ago

>> drivers/gpu/drm/amd/amdgpu/soc15.c:680:3-24: duplicated argument to & or |

git remote add radeon-alex git://people.freedesktop.org/~agd5f/linux.git
git remote update radeon-alex
git checkout 27eab5ad57b2da7803bb3e5d61c666b52b57d6f6
vim +680 drivers/gpu/drm/amd/amdgpu/soc15.c

220ab9bd1 Ken Wang      2017-03-06  599
220ab9bd1 Ken Wang      2017-03-06  600  static int soc15_common_early_init(void *handle)
220ab9bd1 Ken Wang      2017-03-06  601  {
220ab9bd1 Ken Wang      2017-03-06  602          struct amdgpu_device *adev = (struct amdgpu_device *)handle;
220ab9bd1 Ken Wang      2017-03-06  603
220ab9bd1 Ken Wang      2017-03-06  604          adev->smc_rreg = NULL;
220ab9bd1 Ken Wang      2017-03-06  605          adev->smc_wreg = NULL;
220ab9bd1 Ken Wang      2017-03-06  606          adev->pcie_rreg = &soc15_pcie_rreg;
220ab9bd1 Ken Wang      2017-03-06  607          adev->pcie_wreg = &soc15_pcie_wreg;
220ab9bd1 Ken Wang      2017-03-06  608          adev->uvd_ctx_rreg = &soc15_uvd_ctx_rreg;
220ab9bd1 Ken Wang      2017-03-06  609          adev->uvd_ctx_wreg = &soc15_uvd_ctx_wreg;
220ab9bd1 Ken Wang      2017-03-06  610          adev->didt_rreg = &soc15_didt_rreg;
220ab9bd1 Ken Wang      2017-03-06  611          adev->didt_wreg = &soc15_didt_wreg;
560460f28 Evan Quan     2017-07-03  612          adev->gc_cac_rreg = &soc15_gc_cac_rreg;
560460f28 Evan Quan     2017-07-03  613          adev->gc_cac_wreg = &soc15_gc_cac_wreg;
2f11fb028 Evan Quan     2017-07-04  614          adev->se_cac_rreg = &soc15_se_cac_rreg;
2f11fb028 Evan Quan     2017-07-04  615          adev->se_cac_wreg = &soc15_se_cac_wreg;
220ab9bd1 Ken Wang      2017-03-06  616
220ab9bd1 Ken Wang      2017-03-06  617          adev->asic_funcs = &soc15_asic_funcs;
220ab9bd1 Ken Wang      2017-03-06  618
220ab9bd1 Ken Wang      2017-03-06  619          adev->rev_id = soc15_get_rev_id(adev);
220ab9bd1 Ken Wang      2017-03-06  620          adev->external_rev_id = 0xFF;
220ab9bd1 Ken Wang      2017-03-06  621          switch (adev->asic_type) {
220ab9bd1 Ken Wang      2017-03-06  622          case CHIP_VEGA10:
220ab9bd1 Ken Wang      2017-03-06  623                  adev->cg_flags = AMD_CG_SUPPORT_GFX_MGCG |
220ab9bd1 Ken Wang      2017-03-06  624                          AMD_CG_SUPPORT_GFX_MGLS |
220ab9bd1 Ken Wang      2017-03-06  625                          AMD_CG_SUPPORT_GFX_RLC_LS |
220ab9bd1 Ken Wang      2017-03-06  626                          AMD_CG_SUPPORT_GFX_CP_LS |
220ab9bd1 Ken Wang      2017-03-06  627                          AMD_CG_SUPPORT_GFX_3D_CGCG |
220ab9bd1 Ken Wang      2017-03-06  628                          AMD_CG_SUPPORT_GFX_3D_CGLS |
220ab9bd1 Ken Wang      2017-03-06  629                          AMD_CG_SUPPORT_GFX_CGCG |
220ab9bd1 Ken Wang      2017-03-06  630                          AMD_CG_SUPPORT_GFX_CGLS |
220ab9bd1 Ken Wang      2017-03-06  631                          AMD_CG_SUPPORT_BIF_MGCG |
220ab9bd1 Ken Wang      2017-03-06  632                          AMD_CG_SUPPORT_BIF_LS |
220ab9bd1 Ken Wang      2017-03-06  633                          AMD_CG_SUPPORT_HDP_LS |
220ab9bd1 Ken Wang      2017-03-06  634                          AMD_CG_SUPPORT_DRM_MGCG |
220ab9bd1 Ken Wang      2017-03-06  635                          AMD_CG_SUPPORT_DRM_LS |
220ab9bd1 Ken Wang      2017-03-06  636                          AMD_CG_SUPPORT_ROM_MGCG |
220ab9bd1 Ken Wang      2017-03-06  637                          AMD_CG_SUPPORT_DF_MGCG |
220ab9bd1 Ken Wang      2017-03-06  638                          AMD_CG_SUPPORT_SDMA_MGCG |
220ab9bd1 Ken Wang      2017-03-06  639                          AMD_CG_SUPPORT_SDMA_LS |
220ab9bd1 Ken Wang      2017-03-06  640                          AMD_CG_SUPPORT_MC_MGCG |
220ab9bd1 Ken Wang      2017-03-06  641                          AMD_CG_SUPPORT_MC_LS;
220ab9bd1 Ken Wang      2017-03-06  642                  adev->pg_flags = 0;
220ab9bd1 Ken Wang      2017-03-06  643                  adev->external_rev_id = 0x1;
220ab9bd1 Ken Wang      2017-03-06  644                  break;
692069a1a Alex Deucher  2018-03-06  645          case CHIP_VEGA12:
e4a387558 Evan Quan     2017-12-25  646                  adev->cg_flags = AMD_CG_SUPPORT_GFX_MGCG |
e4a387558 Evan Quan     2017-12-25  647                          AMD_CG_SUPPORT_GFX_MGLS |
e4a387558 Evan Quan     2017-12-25  648                          AMD_CG_SUPPORT_GFX_CGCG |
e4a387558 Evan Quan     2017-12-25  649                          AMD_CG_SUPPORT_GFX_CGLS |
e4a387558 Evan Quan     2017-12-25  650                          AMD_CG_SUPPORT_GFX_3D_CGCG |
e4a387558 Evan Quan     2017-12-25  651                          AMD_CG_SUPPORT_GFX_3D_CGLS |
e4a387558 Evan Quan     2017-12-25  652                          AMD_CG_SUPPORT_GFX_CP_LS |
e4a387558 Evan Quan     2017-12-25  653                          AMD_CG_SUPPORT_MC_LS |
e4a387558 Evan Quan     2017-12-25  654                          AMD_CG_SUPPORT_MC_MGCG |
e4a387558 Evan Quan     2017-12-25  655                          AMD_CG_SUPPORT_SDMA_MGCG |
e4a387558 Evan Quan     2017-12-25  656                          AMD_CG_SUPPORT_SDMA_LS |
e4a387558 Evan Quan     2017-12-25  657                          AMD_CG_SUPPORT_BIF_MGCG |
e4a387558 Evan Quan     2017-12-25  658                          AMD_CG_SUPPORT_BIF_LS |
e4a387558 Evan Quan     2017-12-25  659                          AMD_CG_SUPPORT_HDP_MGCG |
e4a387558 Evan Quan     2017-12-25  660                          AMD_CG_SUPPORT_HDP_LS |
e4a387558 Evan Quan     2017-12-25  661                          AMD_CG_SUPPORT_ROM_MGCG |
e4a387558 Evan Quan     2017-12-25  662                          AMD_CG_SUPPORT_VCE_MGCG |
e4a387558 Evan Quan     2017-12-25  663                          AMD_CG_SUPPORT_UVD_MGCG;
692069a1a Alex Deucher  2018-03-06  664                  adev->pg_flags = 0;
f559fe2bc Feifei Xu     2017-12-14  665                  adev->external_rev_id = adev->rev_id + 0x14;
692069a1a Alex Deucher  2018-03-06  666                  break;
935be7a0c Feifei Xu     2018-01-26  667          case CHIP_VEGA20:
27eab5ad5 Evan Quan     2018-03-26  668                  adev->cg_flags = AMD_CG_SUPPORT_GFX_MGCG |
27eab5ad5 Evan Quan     2018-03-26  669                          AMD_CG_SUPPORT_GFX_MGLS |
27eab5ad5 Evan Quan     2018-03-26  670                          AMD_CG_SUPPORT_GFX_CGCG |
27eab5ad5 Evan Quan     2018-03-26  671                          AMD_CG_SUPPORT_GFX_CGLS |
27eab5ad5 Evan Quan     2018-03-26  672                          AMD_CG_SUPPORT_GFX_3D_CGCG |
27eab5ad5 Evan Quan     2018-03-26  673                          AMD_CG_SUPPORT_GFX_3D_CGLS |
27eab5ad5 Evan Quan     2018-03-26  674                          AMD_CG_SUPPORT_GFX_CP_LS |
27eab5ad5 Evan Quan     2018-03-26  675                          AMD_CG_SUPPORT_MC_LS |
27eab5ad5 Evan Quan     2018-03-26  676                          AMD_CG_SUPPORT_MC_MGCG |
27eab5ad5 Evan Quan     2018-03-26  677                          AMD_CG_SUPPORT_SDMA_MGCG |
27eab5ad5 Evan Quan     2018-03-26  678                          AMD_CG_SUPPORT_SDMA_LS |
27eab5ad5 Evan Quan     2018-03-26  679                          AMD_CG_SUPPORT_BIF_MGCG |
27eab5ad5 Evan Quan     2018-03-26 @680                          AMD_CG_SUPPORT_BIF_LS |
27eab5ad5 Evan Quan     2018-03-26  681                          AMD_CG_SUPPORT_HDP_MGCG |
27eab5ad5 Evan Quan     2018-03-26  682                          AMD_CG_SUPPORT_BIF_LS |
27eab5ad5 Evan Quan     2018-03-26  683                          AMD_CG_SUPPORT_ROM_MGCG |
27eab5ad5 Evan Quan     2018-03-26  684                          AMD_CG_SUPPORT_VCE_MGCG |
27eab5ad5 Evan Quan     2018-03-26  685                          AMD_CG_SUPPORT_UVD_MGCG;
935be7a0c Feifei Xu     2018-01-26  686                  adev->pg_flags = 0;
935be7a0c Feifei Xu     2018-01-26  687                  adev->external_rev_id = adev->rev_id + 0x28;
935be7a0c Feifei Xu     2018-01-26  688                  break;
957c6fe18 Hawking Zhang 2016-12-27  689          case CHIP_RAVEN:
5c5928a23 Huang Rui     2017-01-18  690                  adev->cg_flags = AMD_CG_SUPPORT_GFX_MGCG |
5c5928a23 Huang Rui     2017-01-18  691                          AMD_CG_SUPPORT_GFX_MGLS |
5c5928a23 Huang Rui     2017-01-18  692                          AMD_CG_SUPPORT_GFX_RLC_LS |
5c5928a23 Huang Rui     2017-01-18  693                          AMD_CG_SUPPORT_GFX_CP_LS |
5c5928a23 Huang Rui     2017-01-18  694                          AMD_CG_SUPPORT_GFX_3D_CGCG |
5c5928a23 Huang Rui     2017-01-18  695                          AMD_CG_SUPPORT_GFX_3D_CGLS |
5c5928a23 Huang Rui     2017-01-18  696                          AMD_CG_SUPPORT_GFX_CGCG |
5c5928a23 Huang Rui     2017-01-18  697                          AMD_CG_SUPPORT_GFX_CGLS |
5c5928a23 Huang Rui     2017-01-18  698                          AMD_CG_SUPPORT_BIF_MGCG |
5c5928a23 Huang Rui     2017-01-18  699                          AMD_CG_SUPPORT_BIF_LS |
5c5928a23 Huang Rui     2017-01-18  700                          AMD_CG_SUPPORT_HDP_MGCG |
5c5928a23 Huang Rui     2017-01-18  701                          AMD_CG_SUPPORT_HDP_LS |
5c5928a23 Huang Rui     2017-01-18  702                          AMD_CG_SUPPORT_DRM_MGCG |
5c5928a23 Huang Rui     2017-01-18  703                          AMD_CG_SUPPORT_DRM_LS |
c2cdb0ec0 Huang Rui     2017-05-05  704                          AMD_CG_SUPPORT_ROM_MGCG |
c2cdb0ec0 Huang Rui     2017-05-05  705                          AMD_CG_SUPPORT_MC_MGCG |
fe1a3b2e4 Huang Rui     2017-05-05  706                          AMD_CG_SUPPORT_MC_LS |
fe1a3b2e4 Huang Rui     2017-05-05  707                          AMD_CG_SUPPORT_SDMA_MGCG |
fe1a3b2e4 Huang Rui     2017-05-05  708                          AMD_CG_SUPPORT_SDMA_LS;
400b6afba Huang Rui     2017-12-14  709                  adev->pg_flags = AMD_PG_SUPPORT_SDMA;
400b6afba Huang Rui     2017-12-14  710
9ac4b0d95 Huang Rui     2017-12-15  711                  if (adev->powerplay.pp_feature & PP_GFXOFF_MASK)
9ac4b0d95 Huang Rui     2017-12-15  712                          adev->pg_flags |= AMD_PG_SUPPORT_GFX_PG |
9ac4b0d95 Huang Rui     2017-12-15  713                                  AMD_PG_SUPPORT_CP |
9ac4b0d95 Huang Rui     2017-12-15  714                                  AMD_PG_SUPPORT_RLC_SMU_HS;
9ac4b0d95 Huang Rui     2017-12-15  715
957c6fe18 Hawking Zhang 2016-12-27  716                  adev->external_rev_id = 0x1;
957c6fe18 Hawking Zhang 2016-12-27  717                  break;
220ab9bd1 Ken Wang      2017-03-06  718          default:
220ab9bd1 Ken Wang      2017-03-06  719                  /* FIXME: not supported yet */
220ab9bd1 Ken Wang      2017-03-06  720                  return -EINVAL;
220ab9bd1 Ken Wang      2017-03-06  721          }
220ab9bd1 Ken Wang      2017-03-06  722
ab276632e Xiangliang Yu 2017-04-21  723          if (amdgpu_sriov_vf(adev)) {
ab276632e Xiangliang Yu 2017-04-21  724                  amdgpu_virt_init_setting(adev);
ab276632e Xiangliang Yu 2017-04-21  725                  xgpu_ai_mailbox_set_irq_funcs(adev);
ab276632e Xiangliang Yu 2017-04-21  726          }
ab276632e Xiangliang Yu 2017-04-21  727
220ab9bd1 Ken Wang      2017-03-06  728          return 0;
220ab9bd1 Ken Wang      2017-03-06  729  }
220ab9bd1 Ken Wang      2017-03-06  730

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180528/5b12fa07/attachment-0001.html>


More information about the dri-devel mailing list