[PATCH] drm/amd/display: Fix misleading buffer information

Li, Sun peng (Leo) Sunpeng.Li at amd.com
Mon Nov 5 14:51:20 UTC 2018


+amdgfx, amdgpu specific patches should go here

On 2018-11-05 05:33 AM, Shaokun Zhang wrote:
> RETIMER_REDRIVER_INFO shows the buffer as a decimal value with a '0x'
> prefix, which is somewhat misleading.
> 
> Fix it to print hexadecimal, as was intended.
> 
> Fixes: 2f14bc89("drm/amd/display: add retimer log for HWQ tuning use.")
> Cc: Charlene Liu <charlene.liu at amd.com>
> Cc: Dmytro Laktyushkin <Dmytro.Laktyushkin at amd.com>
> Cc: Leo Li <sunpeng.li at amd.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun at hisilicon.com>

Reviewed-by: Leo Li <sunpeng.li at amd.com>

Thanks!
Leo

> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index fb04a4a..5da2186 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -1722,7 +1722,7 @@ static void write_i2c_retimer_setting(
>   		i2c_success = i2c_write(pipe_ctx, slave_address,
>   				buffer, sizeof(buffer));
>   		RETIMER_REDRIVER_INFO("retimer write to slave_address = 0x%x,\
> -			offset = 0x%d, reg_val = 0x%d, i2c_success = %d\n",
> +			offset = 0x%x, reg_val = 0x%x, i2c_success = %d\n",
>   			slave_address, buffer[0], buffer[1], i2c_success?1:0);
>   		if (!i2c_success)
>   			/* Write failure */
> @@ -1734,7 +1734,7 @@ static void write_i2c_retimer_setting(
>   		i2c_success = i2c_write(pipe_ctx, slave_address,
>   				buffer, sizeof(buffer));
>   		RETIMER_REDRIVER_INFO("retimer write to slave_address = 0x%x,\
> -			offset = 0x%d, reg_val = 0x%d, i2c_success = %d\n",
> +			offset = 0x%x, reg_val = 0x%x, i2c_success = %d\n",
>   			slave_address, buffer[0], buffer[1], i2c_success?1:0);
>   		if (!i2c_success)
>   			/* Write failure */
> 


More information about the dri-devel mailing list