[Bug 106175] amdgpu.dc=1 shows performance issues with Xorg compositors when moving windows

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106175

--- Comment #58 from Nicholas Kazlauskas <nicholas.kazlauskas at amd.com> ---
(In reply to Brandon Wright from comment #55)
> Created attachment 142558 [details] [review]
> Patch that "fixes" the problem.
> 
> I've attached a patch that fixes the problem for me. It copies parts from
> the intel patch and uses the existing async infrastructure for the cursor. 
> 
> It's really tiny, so I hope this is helpful enough to get this problem fixed
> quick.

This is a nice attempt but it only resolves the problem because it relies on
the blocking behavior in atomic check that amdgpu_dm currently does (and
shouldn't be doing).

Asynchronous updates can and will occur in parallel with other commits on
worker threads. Without the wait in atomic_check you'll see the IGT legacy
cursor tests break with this patch (and there will probably be system faults as
well).

There are larger problems within amdgpu_dm's commit tail that if addressed
should resolve this issue for compton I'd imagine.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20181122/485d9191/attachment.html>