[PATCH DRM] drm: msm: Use DRM_DEV_* instead of dev_*

Chris Wilson chris at chris-wilson.co.uk
Mon Oct 22 19:22:57 UTC 2018


Quoting Mamta Shukla (2018-10-20 18:49:26)
> Use DRM_DEV_INFO/ERROR/WARN instead of dev_info/err/debug to generate
> drm-formatted specific log messages so that it will be easy to
> differentiate in case of multiple instances of driver.

Do you not think this is a bit backwards? Both dev_* and DRM_DEV_*
include the device id so that multiple instances can be distinguished.
What DRM_DEV_* adds is the function name, which for user facing messages
should not be required given a self-encapsulating informative message.
-Chris


More information about the dri-devel mailing list