[PATCH DRM] drm: msm: Use DRM_DEV_* instead of dev_*

Sean Paul sean at poorly.run
Tue Oct 23 16:41:22 UTC 2018


On Mon, Oct 22, 2018 at 08:22:57PM +0100, Chris Wilson wrote:
> Quoting Mamta Shukla (2018-10-20 18:49:26)
> > Use DRM_DEV_INFO/ERROR/WARN instead of dev_info/err/debug to generate
> > drm-formatted specific log messages so that it will be easy to
> > differentiate in case of multiple instances of driver.
> 
> Do you not think this is a bit backwards? Both dev_* and DRM_DEV_*
> include the device id so that multiple instances can be distinguished.
> What DRM_DEV_* adds is the function name, which for user facing messages
> should not be required given a self-encapsulating informative message.

"given a self-encapsulating informative message." being the key here. I'm not
sure about i915, but most other drivers have vague/duplicated log messages which
rely on the function name for differentiation.

Sean

> -Chris

-- 
Sean Paul, Software Engineer, Google / Chromium OS


More information about the dri-devel mailing list