[PATCH 15/20] drm/sun4i: Use drm_fbdev_generic_setup()

Maxime Ripard maxime.ripard at bootlin.com
Mon Sep 10 07:28:54 UTC 2018


On Sat, Sep 08, 2018 at 03:46:43PM +0200, Noralf Trønnes wrote:
> The CMA helper is already using the drm_fb_helper_generic_probe part of
> the generic fbdev emulation. This patch makes full use of the generic
> fbdev emulation by using its drm_client callbacks. This means that
> drm_mode_config_funcs->output_poll_changed and drm_driver->lastclose are
> now handled by the emulation code. Additionally fbdev unregister happens
> automatically on drm_dev_unregister().
> 
> The drm_fbdev_generic_setup() call is put after drm_dev_register() in the
> driver. This is done to highlight the fact that fbdev emulation is an
> internal client that makes use of the driver, it is not part of the
> driver as such. If fbdev setup fails, an error is printed, but the driver
> succeeds probing.
> 
> Cc: Maxime Ripard <maxime.ripard at bootlin.com>
> Signed-off-by: Noralf Trønnes <noralf at tronnes.org>

It's hard to tell anything about this patch without context, but is
the mali userspace still broken?

Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180910/9a212e4a/attachment.sig>


More information about the dri-devel mailing list