[PATCH 15/20] drm/sun4i: Use drm_fbdev_generic_setup()

Noralf Trønnes noralf at tronnes.org
Mon Sep 10 12:57:12 UTC 2018


Den 10.09.2018 09.28, skrev Maxime Ripard:
> On Sat, Sep 08, 2018 at 03:46:43PM +0200, Noralf Trønnes wrote:
>> The CMA helper is already using the drm_fb_helper_generic_probe part of
>> the generic fbdev emulation. This patch makes full use of the generic
>> fbdev emulation by using its drm_client callbacks. This means that
>> drm_mode_config_funcs->output_poll_changed and drm_driver->lastclose are
>> now handled by the emulation code. Additionally fbdev unregister happens
>> automatically on drm_dev_unregister().
>>
>> The drm_fbdev_generic_setup() call is put after drm_dev_register() in the
>> driver. This is done to highlight the fact that fbdev emulation is an
>> internal client that makes use of the driver, it is not part of the
>> driver as such. If fbdev setup fails, an error is printed, but the driver
>> succeeds probing.
>>
>> Cc: Maxime Ripard <maxime.ripard at bootlin.com>
>> Signed-off-by: Noralf Trønnes <noralf at tronnes.org>
> It's hard to tell anything about this patch without context, but is
> the mali userspace still broken?

I replied to the cover letter with more context.

If that's the smem_start  thing, then yes.
This patch will block smem_start from being used by any DRM driver:
drm/fb: Stop leaking physical address
https://patchwork.freedesktop.org/patch/245514/

Noralf.



More information about the dri-devel mailing list