[PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

Russell King - ARM Linux linux at armlinux.org.uk
Thu Sep 13 13:48:55 UTC 2018


On Thu, Sep 13, 2018 at 03:33:20PM +0200, Hans Verkuil wrote:
> On 09/13/18 15:16, Daniel Vetter wrote:
> > On Thu, Sep 13, 2018 at 10:33:35AM +0100, Russell King - ARM Linux wrote:
> >> Hi Hans,
> >>
> >> I'll pick it up in due course.
> >>
> >> Thanks.
> >>
> >> On Tue, Sep 11, 2018 at 08:41:59AM +0200, Hans Verkuil wrote:
> >>> Russell (or someone else), can you Ack this patch? I'd like to get this
> >>> for 4.20.
> >>>
> >>> Thanks!
> >>>
> >>> 	Hans
> >>>
> >>> On 08/27/2018 02:28 PM, Hans Verkuil wrote:
> >>>> The CEC_TX_STATUS_MAX_RETRIES should be set for errors only to
> >>>> prevent the CEC framework from retrying the transmit. If the
> >>>> transmit was successful, then don't set this flag.
> >>>>
> >>>> Found by running 'cec-compliance -A' on a beaglebone box.
> >>>>
> >>>> Signed-off-by: Hans Verkuil <hans.verkuil at cisco.com>
> > 
> > Since the tda driver is now a brideg one, would make sense to maintain it
> > as part of drm-misc? Hans could push directly then.
> 
> It isn't yet part of drm-misc? It would make sense IMHO.
> 
> And 'due course' is too vague since this should be merged for 4.20.

Given that we are at 4.19-rc3, and you are talking about it being merged
during the _next_ merge window, there is plenty of time remaining that
waiting another week or two for me to pick it up is not a problem.

In any case, my plan is to merge it for 4.19 since it appears to be a
bug fix, albiet a minor one.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
According to speedtest.net: 13Mbps down 490kbps up


More information about the dri-devel mailing list