[Bug 110354] Confusing Junk in the results: Last errno: 25, Inappropriate ioctl for device

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=110354

Arek Hiler <arkadiusz.hiler at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Arek Hiler <arkadiusz.hiler at intel.com> ---
There was a patch merged that resets errno in the few places where errno
pollution is likely and in the few places where it may require resetting:

commit a558c2e2405473f4157ca71638e5a111ebfa80d1
Author: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
Date:   Tue Apr 9 17:21:41 2019 +0300

    lib: Reset errno to 0 after isatty

    Since igt_assert family of functions logs last errno we get a lot of
    those: "Last errno: 25, Inappropriate ioctl for device"

    isatty() seems to be the biggest offender in that area, so this patch
    should limit amount of confusing messages significantly.

    Cc: Martin Peres <martin.peres at linux.intel.com>
    Cc: Petri Latvala <petri.latvala at intel.com>
    Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
    Reviewed-by: Petri Latvala <petri.latvala at intel.com>

commit 02b1706e8b1ca93a53d4ef0f9c484a6f1a0d18f2
Author: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
Date:   Thu Apr 4 16:17:40 2019 +0300

    lib/igt_kms: Be more verbose about failure in kmstest_wait_for_pageflip

    First, we set errno to 0 before doing select() to avoid random pollution
    of the assert message with things like:
    "Last errno: 25, Inappropriate ioctl for device"

    Second, we log explicitly if we exceeded the timeout (ret == 0).

    Third, if we fail the select() we log that with some explanation.

    Cc: Petri Latvala <petri.latvala at intel.com>
    Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
    Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
    Reviewed-by: Petri Latvala <petri.latvala at intel.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20190806/df74abc5/attachment.html>