[PATCH v2 6/9] drm: rcar-du: lvds: Fix companion's mode
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Thu Aug 15 11:55:17 UTC 2019
Hi Fabrizio,
Thank you for the patch.
On Thu, Aug 15, 2019 at 12:04:30PM +0100, Fabrizio Castro wrote:
> The companion encoder needs to be told to use the same
> mode as the primary encoder.
>
> Fixes: e9e8798ab7b8 ("drm: rcar-du: lvds: Add support for dual-link mode")
> Signed-off-by: Fabrizio Castro <fabrizio.castro at bp.renesas.com>
>
> ---
> v1->v2:
> * reworked according to Laurent's feedback
>
> drivers/gpu/drm/rcar-du/rcar_lvds.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> index 3fe0b86..41d28f4 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> @@ -603,6 +603,11 @@ static void rcar_lvds_mode_set(struct drm_bridge *bridge,
> lvds->display_mode = *adjusted_mode;
>
> rcar_lvds_get_lvds_mode(lvds);
> + if (lvds->companion) {
> + struct rcar_lvds *companion_lvds = bridge_to_rcar_lvds(
> + lvds->companion);
> + companion_lvds->mode = lvds->mode;
How about calling rcar_lvds_mode_set() on the companion instead ?
> + }
> }
>
> static int rcar_lvds_attach(struct drm_bridge *bridge)
--
Regards,
Laurent Pinchart
More information about the dri-devel
mailing list