[PATCH v4 12/19] drm/bochs: Convert bochs driver to VRAM MM
Gerd Hoffmann
kraxel at redhat.com
Mon May 6 12:40:31 UTC 2019
Hi,
> static const struct file_operations bochs_fops = {
> .owner = THIS_MODULE,
> - .open = drm_open,
> - .release = drm_release,
> - .unlocked_ioctl = drm_ioctl,
> - .compat_ioctl = drm_compat_ioctl,
> - .poll = drm_poll,
> - .read = drm_read,
> .llseek = no_llseek,
> - .mmap = bochs_mmap,
> + DRM_VRAM_MM_FILE_OPERATIONS
> };
What about llseek? I think it should either be deleted (if not needed)
or added to DRM_VRAM_MM_FILE_OPERATIONS (if needed).
cheers,
Gerd
More information about the dri-devel
mailing list