[PATCH v4 12/19] drm/bochs: Convert bochs driver to VRAM MM

[Thomas Zimmermann]

Hi

Am 06.05.19 um 14:40 schrieb Gerd Hoffmann:
>   Hi,
> 
>>  static const struct file_operations bochs_fops = {
>>  	.owner		= THIS_MODULE,
>> -	.open		= drm_open,
>> -	.release	= drm_release,
>> -	.unlocked_ioctl	= drm_ioctl,
>> -	.compat_ioctl	= drm_compat_ioctl,
>> -	.poll		= drm_poll,
>> -	.read		= drm_read,
>>  	.llseek		= no_llseek,
>> -	.mmap           = bochs_mmap,
>> +	DRM_VRAM_MM_FILE_OPERATIONS
>>  };
> 
> What about llseek?  I think it should either be deleted (if not needed)
> or added to DRM_VRAM_MM_FILE_OPERATIONS (if needed).

Some drivers set no_llseek, some leave the .llseek field to NULL. So I
don't set the field from DRM_VRAM_MM_FILE_OPERATIONS.

But now that you asked, I found that DRM actually requires no_llseek.
I'll add it to the default operations in the next iteration of the patch
set.

Best regards
Thomas

> cheers,
>   Gerd
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20190506/a0e25586/attachment-0001.sig>