[PATCHv2 7/7] drm/omap: hdmi4: fix use of uninitialized var
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Fri Oct 4 07:03:05 UTC 2019
Hi Tomi,
Thank you for the patch.
On Mon, Sep 30, 2019 at 01:38:40PM +0300, Tomi Valkeinen wrote:
> If use_mclk is false, mclk_mode is written to a register without
> initialization. This doesn't cause any ill effects as the written value
> is not used when use_mclk is false.
>
> To fix this, write use_mclk only when use_mclk is true.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ti.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c
> index 5d5d5588ebc1..c4ffe96e28bc 100644
> --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c
> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c
> @@ -542,8 +542,9 @@ static void hdmi_core_audio_config(struct hdmi_core_data *core,
> }
>
> /* Set ACR clock divisor */
> - REG_FLD_MOD(av_base,
> - HDMI_CORE_AV_FREQ_SVAL, cfg->mclk_mode, 2, 0);
> + if (cfg->use_mclk)
> + REG_FLD_MOD(av_base, HDMI_CORE_AV_FREQ_SVAL,
> + cfg->mclk_mode, 2, 0);
>
> r = hdmi_read_reg(av_base, HDMI_CORE_AV_ACR_CTRL);
> /*
--
Regards,
Laurent Pinchart
More information about the dri-devel
mailing list