[PATCHv2 7/7] drm/omap: hdmi4: fix use of uninitialized var

Tony Lindgren tony at atomide.com
Tue Oct 8 14:13:35 UTC 2019


* Tomi Valkeinen <tomi.valkeinen at ti.com> [190930 10:38]:
> If use_mclk is false, mclk_mode is written to a register without
> initialization. This doesn't cause any ill effects as the written value
> is not used when use_mclk is false.
> 
> To fix this, write use_mclk only when use_mclk is true.

Hey nice catch. Based on a quick test looks like this fixes an
issue where power consumption stays higher after using HDMI.

Would be nice to have merged in the v5.4-rc series:

Tested-by: Tony Lindgren <tony at atomide.com>


More information about the dri-devel mailing list