Aw: Re: [PATCH v3 5/5] arm: dts: mt7623: add display subsystem related device nodes

Frank Wunderlich frank-w at public-files.de
Tue Aug 4 15:38:43 UTC 2020


> Gesendet: Dienstag, 04. August 2020 um 17:00 Uhr
> Von: "Chun-Kuang Hu" <chunkuang.hu at kernel.org>

> > +       display_components: dispsys at 14000000 {
> > +               compatible = "mediatek,mt7623-mmsys",
> > +                            "mediatek,mt2701-mmsys";
>
> In mediatek,mmsys.txt [3], this should be:
>
> mmsys: syscon at 14000000 {
>         compatible = "mediatek,mt7623-mmsys", "mediatek,mt2701-mmsys", "syscon"
>
> [3] https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/mediatek/mediatek%2Cmmsys.txt

oh i see i can drop this because there is already a mmsys-node with the compatibles from documentation.
only powerdomain is missing, but this seems not be needed (hdmi works without this "display_components" node)...

    mmsys: syscon at 14000000 {
        compatible = "mediatek,mt7623-mmsys",
                 "mediatek,mt2701-mmsys",
                 "syscon";
        reg = <0 0x14000000 0 0x1000>;
        #clock-cells = <1>;
    };

    display_components: dispsys at 14000000 {
        compatible = "mediatek,mt7623-mmsys",
                 "mediatek,mt2701-mmsys";
        reg = <0 0x14000000 0 0x1000>;
        power-domains = <&scpsys MT2701_POWER_DOMAIN_DISP>;
    };


More information about the dri-devel mailing list