[PATCH] drm/malidp: Use struct drm_gem_object_funcs.get_sg_table internally

[Daniel Vetter]

On Fri, Aug 07, 2020 at 01:10:22PM +0200, Thomas Zimmermann wrote:
> The malidp driver uses GEM object functions for callbacks. Fix it to
> use them internally as well.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> Fixes: ecdd6474644f ("drm/malidp: Use GEM CMA object functions")
> Cc: Thomas Zimmermann <tzimmermann at suse.de>
> Cc: Emil Velikov <emil.velikov at collabora.com>
> Cc: Liviu Dudau <liviu.dudau at arm.com>
> Cc: Brian Starkey <brian.starkey at arm.com>
> ---
>  drivers/gpu/drm/arm/malidp_planes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> index ab45ac445045..351a85088d0e 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -346,7 +346,7 @@ static bool malidp_check_pages_threshold(struct malidp_plane_state *ms,
>  		if (cma_obj->sgt)
>  			sgt = cma_obj->sgt;
>  		else
> -			sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
> +			sgt = obj->funcs->get_sg_table(obj);

Uh if there's not a switch somewhere I'd just call the right function
directly. Or call the right wrapper for this, this feels a bit fishy ...
-Daniel

>  
>  		if (!sgt)
>  			return false;
> -- 
> 2.28.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch