[PATCH] drm/malidp: Use struct drm_gem_object_funcs.get_sg_table internally

[Thomas Zimmermann]

Hi

Am 07.08.20 um 15:12 schrieb Daniel Vetter:
> On Fri, Aug 07, 2020 at 01:10:22PM +0200, Thomas Zimmermann wrote:
>> The malidp driver uses GEM object functions for callbacks. Fix it to
>> use them internally as well.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
>> Fixes: ecdd6474644f ("drm/malidp: Use GEM CMA object functions")
>> Cc: Thomas Zimmermann <tzimmermann at suse.de>
>> Cc: Emil Velikov <emil.velikov at collabora.com>
>> Cc: Liviu Dudau <liviu.dudau at arm.com>
>> Cc: Brian Starkey <brian.starkey at arm.com>
>> ---
>>  drivers/gpu/drm/arm/malidp_planes.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
>> index ab45ac445045..351a85088d0e 100644
>> --- a/drivers/gpu/drm/arm/malidp_planes.c
>> +++ b/drivers/gpu/drm/arm/malidp_planes.c
>> @@ -346,7 +346,7 @@ static bool malidp_check_pages_threshold(struct malidp_plane_state *ms,
>>  		if (cma_obj->sgt)
>>  			sgt = cma_obj->sgt;
>>  		else
>> -			sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
>> +			sgt = obj->funcs->get_sg_table(obj);
> 
> Uh if there's not a switch somewhere I'd just call the right function
> directly. Or call the right wrapper for this, this feels a bit fishy ...

The driver initializes the pointer via CMA helper macro to an
CMA-internal default. Calling the actual function here is fragile if the
CMA-internal default ever changes.

But I have no strong feelings. I'll go with whatever the driver's
maintainer prefers.

Best regards
Thomas

> -Daniel
> 
>>  
>>  		if (!sgt)
>>  			return false;
>> -- 
>> 2.28.0
>>
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 516 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20200807/13cfb3a9/attachment.sig>