[PATCH RFC v3 3/6] dt-bindings: display: add Unisoc's dpu bindings

[tang pengchuan]

On Sat, Feb 22, 2020 at 5:39 AM Sam Ravnborg <sam at ravnborg.org> wrote:

> Hi Kevin.
>
> On Fri, Feb 21, 2020 at 03:48:53PM +0800, Kevin Tang wrote:
> > From: Kevin Tang <kevin.tang at unisoc.com>
> >
> > DPU (Display Processor Unit) is the Display Controller for the Unisoc
> SoCs
> > which transfers the image data from a video memory buffer to an internal
> > LCD interface.
> >
> > Cc: Orson Zhai <orsonzhai at gmail.com>
> > Cc: Baolin Wang <baolin.wang at linaro.org>
> > Cc: Chunyan Zhang <zhang.lyra at gmail.com>
> > Signed-off-by: Kevin Tang <kevin.tang at unisoc.com>
> > ---
> >  .../devicetree/bindings/display/sprd/dpu.yaml      | 85
> ++++++++++++++++++++++
> >  1 file changed, 85 insertions(+)
> >  create mode 100644
> Documentation/devicetree/bindings/display/sprd/dpu.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/sprd/dpu.yaml
> b/Documentation/devicetree/bindings/display/sprd/dpu.yaml
> > new file mode 100644
> > index 0000000..7695d94
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/sprd/dpu.yaml
> > @@ -0,0 +1,85 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/sprd/dpu.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Unisoc SoC Display Processor Unit (DPU)
> > +
> > +maintainers:
> > +  - David Airlie <airlied at linux.ie>
> > +  - Daniel Vetter <daniel at ffwll.ch>
> > +  - Rob Herring <robh+dt at kernel.org>
> > +  - Mark Rutland <mark.rutland at arm.com>
> > +
> > +description: |
> > +  DPU (Display Processor Unit) is the Display Controller for the Unisoc
> SoCs
> > +  which transfers the image data from a video memory buffer to an
> internal
> > +  LCD interface.
> > +
> > +properties:
> > +  compatible:
> > +    const: sprd,sharkl3-dpu
> > +
> > +  reg:
> > +    maxItems: 1
> > +    description:
> > +      Physical base address and length of the DPU registers set
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +    description:
> > +      The interrupt signal from DPU
> > +
> > +  clocks:
> > +    minItems: 2
> Should this be maxItems: 2?
> That would imply minItems: 2.
>
We need minItems: 2, one is for display controller, one is for dpi clock

>
>
> > +
> > +  clock-names:
> > +    items:
> > +      - const: clk_src_128m
> > +      - const: clk_src_384m
> > +
> > +  power-domains:
> > +    description: A phandle to DPU power domain node.
> > +
> > +  iommus:
> > +    description: A phandle to DPU iommu node.
> > +
> > +  port:
> > +    type: object
> > +    description:
> > +      A port node with endpoint definitions as defined in
> > +      Documentation/devicetree/bindings/media/video-interfaces.txt.
> > +      That port should be the output endpoint, usually output to
> > +      the associated DSI.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +  - clock-names
> > +  - port
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/clock/sprd,sc9860-clk.h>
> > +    dpu: dpu at 0x63000000 {
> > +          compatible = "sprd,sharkl3-dpu";
> > +          reg = <0x0 0x63000000 0x0 0x1000>;
> > +          interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>;
> > +          clock-names = "clk_src_128m",
> > +                     "clk_src_384m";
> > +
> > +          clocks = <&pll CLK_TWPLL_128M>,
> > +                <&pll CLK_TWPLL_384M>;
> > +
> > +          dpu_port: port {
> > +                  dpu_out: endpoint {
> > +                          remote-endpoint = <&dsi_in>;
> > +                  };
> > +          };
> > +    };
> Did this example pass dt_binding_check with no warnings?
> I wonder how the reg property could avoid generating warnings as the
> upper node do not have #address_cells, #node_cells
>
Yes, pass dt_binding_check with no warnings
Because our display controller is under ahb bus or apb bus, parent node
have defined "address-cells" and "size-cells"
So subdev is omitted

>
>         Sam
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20200223/68a18655/attachment-0001.htm>