[PATCH] drm/vc4: fix ref count leak in vc4_dsi_encoder_enable

Andy Shevchenko andy.shevchenko at gmail.com
Sun Jun 14 12:32:39 UTC 2020


On Sun, Jun 14, 2020 at 9:55 AM Navid Emamdoost
<navid.emamdoost at gmail.com> wrote:
>
> in vc4_dsi_encoder_enable, the call to pm_runtime_get_sync increments
> the counter even in case of failure, leading to incorrect
> ref count. In case of failure, decrement the ref count before returning.

...

> +out:
> +       pm_runtime_put(dev);

Better to use pm_runtime_put_noidle() for error case.
And here is a change of semantics, i.e. before your patch there was no
put at all. How did you test this?

-- 
With Best Regards,
Andy Shevchenko


More information about the dri-devel mailing list