[PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit

Markus Elfring Markus.Elfring at web.de
Sun Jun 14 11:31:09 UTC 2020


> in panfrost_job_hw_submit, …

* Can the term “reference count” become relevant also for this commit message
  besides other possible adjustments?

* Would you like to add the tag “Fixes”?


…
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
…
> @@ -184,6 +183,9 @@  static void panfrost_job_hw_submit(struct panfrost_job *job, int js)
>  				job, js, jc_head);
>
>  	job_write(pfdev, JS_COMMAND_NEXT(js), JS_COMMAND_START);
> +out:
> +	pm_runtime_put_sync_autosuspend(pfdev->dev);
> +	return;
>  }
…

Perhaps use the label “put_sync” instead?

Regards,
Markus


More information about the dri-devel mailing list