[RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

Dexuan Cui decui at microsoft.com
Tue Jun 23 02:31:20 UTC 2020


> From: linux-hyperv-owner at vger.kernel.org
> <linux-hyperv-owner at vger.kernel.org> On Behalf Of Deepak Rawat
> Sent: Monday, June 22, 2020 4:06 AM
> 
> DRM driver for hyperv synthetic video device, based on hyperv_fb
> framebuffer driver. Also added config option "DRM_HYPERV" to enabled
> this driver.

Hi Deepak,
I had a quick look and overall the patch as v1 looks good to me. 

Some quick comments:
1. hyperv_vmbus_probe() assumes the existence of the PCI device, which
is not true in a Hyper-V Generation-2 VM.

2. It looks some other functionality in the hyperv_fb driver has not been
implemented in this new driver either, e.g. the handling of the
SYNTHVID_FEATURE_CHANGE msg.

Thanks,
-- Dexuan


More information about the dri-devel mailing list