[RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

[Thomas Zimmermann]

Hi

Am 23.06.20 um 11:12 schrieb Deepak Rawat:
> On Tue, 2020-06-23 at 09:59 +0200, Thomas Zimmermann wrote:
>> Hi Deepak
>>
>> I did not receive you pat series, so I can only comment on Sam's
>> reply.
>> See below for some points.
> 
> Hi Thomas, Thanks for the review. I wanted to add you in cc list but
> messed it up with final git send-email. Sorry about that. I am not sure
> why you didn't received it via dri-devel. The patch series do show up
> in dri-devel archive. I wonder if other people also have similar
> issues.

I think it's related to a problem on my side. Some of my email
infrastructure was not available over the weekend.

Best regards
Thomas

> 
> 
>>>>
>>>> +	struct hv_device *hdev;
>>>> +};
>>>> +
>>>> +#define to_hv(_dev) container_of(_dev, struct hyperv_device,
>>>> dev)
>>
>> Could this be a function?
> 
> Is there a reason to use a function here?
> 
>>
>>>> +
>>>> +/* -----------------------------------------------------------
>>>> ----------- */
>>>> +/* Hyper-V Synthetic Video
>>>> Protocol                                       */
>>
>> The comments look awkward. Unless this style has been used within
>> DRM,
>> maybe just use
>>
>>  /*
>>   * ...
>>   */
>>
> 
> This style is copy-paste from cirrus, and bochs also have same style.
> Perhaps historical. Anyway I agree to I should get rid of this.
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20200623/ddc9fd67/attachment.sig>