[PATCH v1 32/36] dt-bindings: display: convert sharp, ls037v7dw01 to DT Schema

Sam Ravnborg sam at ravnborg.org
Sun Mar 29 19:03:52 UTC 2020


Hi Rob.

> > +
> > +  mode-gpios:
> > +    description: |
> > +      GPIO ordered MO, LR, and UD as specified in LS037V7DW01.pdf
> 
> 3 or...
> 
> > +      change configuration between QVGA and VGA mode and the
> > +      scan direction. As these pins can be also configured
> > +      with external pulls, all the GPIOs are considered
> > +      optional with holes in the array.
> 
> minItems: 3
> maxItems: 5

This binding can specify up to three GPIOs like this:


> > +        mode-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH        /* gpio154, lcd MO */
> > +                      &gpio1 2 GPIO_ACTIVE_HIGH         /* gpio2, lcd LR */
> > +                      &gpio1 3 GPIO_ACTIVE_HIGH>;       /* gpio3, lcd UD */

They are in the linux kernel driver accessed like this:

    devm_gpiod_get_index(&pdev->dev, "mode", 2, GPIOD_OUT_LOW);

The following is OK in the DT file:

    mode-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH>;

    mode-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH
                  &gpio1 2 GPIO_ACTIVE_HIGH>;
		  
    mode-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH
                  &gpio1 2 GPIO_ACTIVE_HIGH
                  &gpio1 3 GPIO_ACTIVE_HIGH>;

But the following is not OK:
    mode-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH>, <&gpio1 2 GPIO_ACTIVE_HIGH>;

Any hints how to specify the binding to prevent the above?
I have tried a few combinations - but they do not catch this.
So my binding attempts are not restrictive enough.

Any hints how to describe this properly?

	Sam


More information about the dri-devel mailing list