[PATCH v2 2/2] drm/auth: make drm_{set,drop]master_ioctl symmetrical

Sam Ravnborg sam at ravnborg.org
Sat May 30 13:43:34 UTC 2020


On Sat, May 30, 2020 at 02:34:10PM +0100, Emil Velikov wrote:
> On Sat, 30 May 2020 at 14:18, Sam Ravnborg <sam at ravnborg.org> wrote:
> >
> > Hi Emil.
> > On Sat, May 30, 2020 at 01:46:40PM +0100, Emil Velikov wrote:
> > > Currently the ret handling is all over the place - with two redundant
> > > assignments and another one addressed earlier.
> > >
> > > Use the exact same flow in both functions.
> > >
> > > v2: straighten the code flow, instead of just removing the assignments
> > Now even I should be able to follow the flow - thanks :-)
> >
> Fwiw reading at the code the first couple of times, did confuse the
> hell out of me.
> So "there is nothing wrong with your television set" :-P
> 
> > >
> > > Cc: David Airlie <airlied at linux.ie>
> > > Cc: Daniel Vetter <daniel at ffwll.ch>
> > > Cc: Sam Ravnborg <sam at ravnborg.org>
> > > Cc: Colin Ian King <colin.king at canonical.com>
> > > Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> > Reviewed-by: Sam Ravnborg <sam at ravnborg.org>
> 
> Thanks. If you're up for a few more neat patches - check these out [1].
> 
> -Emil
> 
> [1] https://patchwork.freedesktop.org/series/76967/

On my backlog. They require, I think, a bit more time.
backlog atm is way too big - but thats a common issue for everyone.

	Sam


More information about the dri-devel mailing list