[PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()

Markus Elfring Markus.Elfring at web.de
Sun May 31 08:03:19 UTC 2020

> When gk20a_clk_ctor() returns an error code, pointer "clk"
> should be released.

Such an information is reasonable.

> It's the same when gm20b_clk_new() returns from elsewhere following this call.

I suggest to reconsider the interpretation of the software situation once more.
Can it be that the allocated clock object should be kept usable even after
a successful return from this function?

Would you like to add the tag “Fixes” to the commit message?


More information about the dri-devel mailing list