[PATCH 02/12] drm/mgag200: Return errno codes from PLL compute functions
Thomas Zimmermann
tzimmermann at suse.de
Mon Jul 5 12:45:05 UTC 2021
Return -EINVAL if there's no PLL configuration for the given pixel
clock.
Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
index 482843ebb69f..045a20055515 100644
--- a/drivers/gpu/drm/mgag200/mgag200_mode.c
+++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
@@ -134,7 +134,7 @@ static int mgag200_g200_set_plls(struct mga_device *mdev, long clock)
if (clock > p_clk_max) {
drm_err(dev, "Pixel Clock %ld too high\n", clock);
- return 1;
+ return -EINVAL;
}
if (clock < p_clk_min >> 3)
@@ -293,7 +293,7 @@ static int mga_g200se_set_plls(struct mga_device *mdev, long clock)
if (delta > permitteddelta) {
pr_warn("PLL delta too large\n");
- return 1;
+ return -EINVAL;
}
misc = RREG8(MGA_MISC_IN);
--
2.32.0
More information about the dri-devel
mailing list