[PATCH 0/4] Nuke legacy hw_id

Lucas De Marchi lucas.demarchi at intel.com
Tue Jul 20 23:20:10 UTC 2021


Motivated by my review in
https://patchwork.freedesktop.org/patch/443857/?series=92135&rev=5 I
went to look why we needed the additional hw_id fields. It turns out we
don't, but we kept adding new IDs to keep it consistent. Now that with
the extra media engines we would just leave than zero'ed, let's refactor
the code so we don't keep them around: they aren't used since
GRAPHICS_VER == 8.

I'd say last patch is a stretch due to the use of _PICK() and hardcoding
the map, but to me it seems to avoid making it more complex elsewhere.

Lucas De Marchi (4):
  drm/i915/gt: fix platform prefix
  drm/i915/gt: nuke unused legacy engine hw_id
  drm/i915/gt: rename legacy engine->hw_id to engine->gen6_hw_id
  drm/i915/gt: nuke gen6_hw_id

 drivers/gpu/drm/i915/gt/intel_engine_cs.c    | 10 ----------
 drivers/gpu/drm/i915/gt/intel_engine_types.h | 12 ------------
 drivers/gpu/drm/i915/gt/intel_gt.c           |  4 ++--
 drivers/gpu/drm/i915/i915_reg.h              |  4 +++-
 4 files changed, 5 insertions(+), 25 deletions(-)

-- 
2.31.1



More information about the dri-devel mailing list