[PATCH v2 0/5] drm/vc4: hdmi: Support the 4k @ 60Hz modes

[Thomas Zimmermann]

Hi,

I looked through the patches. I can't say much about the technical side, 
but for the patches themselves

Acked-by: Thomas Zimmermann <tzimmermann at suse.de>

Just one nit: I've seen the pattern

   (mode->clock * 1000) < HDMI_14_MAX_TMDS_CLK

in several places. I suggest to add a little helper with a descriptive name.

Best regards
Thomas

Am 18.03.21 um 10:29 schrieb Maxime Ripard:
> Hi,
> 
> Here is a series that enables the higher resolutions on the HDMI0 Controller
> found in the BCM2711 (RPi4).
> 
> In order to work it needs a few adjustments to config.txt, most notably to
> enable the enable_hdmi_4kp60 option.
> 
> The firmware also has a glitch at the moment and will not properly release the
> BSC controllers, which will make the EDID retrieval fail.
> 
> We can work around this using the following config.txt options:
> 
> disable_fw_kms_setup=1
> hdmi_edid_file:0=1
> hdmi_edid_filename:0=1366x768.bin
> hdmi_ignore_edid:0=1
> hdmi_edid_file:1=1
> hdmi_edid_filename:1=1366x768.bin
> hdmi_ignore_edid:1=1
> 
> A fix will come for the firmware eventually.
> 
> Let me know what you think,
> Maxime
> 
> ---
> 
> Changes from v1:
>    - Dropped the range accessors
>    - Drop the mention of force_turbo
>    - Reordered the SCRAMBLER_CTL register to match the offset
>    - Removed duplicate HDMI_14_MAX_TMDS_CLK define
>    - Warn about enable_hdmi_4kp60 only if there's some modes that can't be reached
>    - Rework the BVB clock computation
> 
> Maxime Ripard (5):
>    drm/vc4: hvs: Make the HVS bind first
>    drm/vc4: hdmi: Properly compute the BVB clock rate
>    drm/vc4: hdmi: Check and warn if we can't reach 4kp60 frequencies
>    drm/vc4: hdmi: Enable the scrambler
>    drm/vc4: hdmi: Raise the maximum clock rate
> 
>   drivers/gpu/drm/vc4/vc4_drv.c       |  11 ++-
>   drivers/gpu/drm/vc4/vc4_hdmi.c      | 101 +++++++++++++++++++++++++---
>   drivers/gpu/drm/vc4/vc4_hdmi.h      |   8 +++
>   drivers/gpu/drm/vc4/vc4_hdmi_regs.h |   3 +
>   4 files changed, 113 insertions(+), 10 deletions(-)
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20210319/4922ce12/attachment-0001.sig>