[PATCH v2] drm: log errors in drm_gem_fb_init_with_funcs
Simon Ser
contact at emersion.fr
Wed May 5 06:06:00 UTC 2021
On Wednesday, May 5th, 2021 at 2:14 AM, Rodrigo Siqueira <Rodrigo.Siqueira at amd.com> wrote:
> > As Ville said, if things got this far and the format is unsupported, something
> > must be going wrong. I'm not confident enough to switch this to a WARN_ON,
> > though.
>
> Hi Simon, thanks for your explanation.
>
> Is it common to get "!info" equal true? If not, and imho, I think that
> WARN_ON would be good to raise attention to a possible issue.
Maybe, but:
- I don't know enough to tell.
- Should be a separate patch anyway if we want to go with this, so that
the WARN_ON can easily be reverted if need be (without reverting the
logging additions).
More information about the dri-devel
mailing list