[PATCH v2 1/4] drm/vmwgfx: Stop using 'TRUE'

[Zack Rusin]

On Jun 30, 2022, at 3:51 PM, Ville Syrjala <ville.syrjala at linux.intel.com<mailto:ville.syrjala at linux.intel.com>> wrote:

From: Ville Syrjälä <ville.syrjala at linux.intel.com<mailto:ville.syrjala at linux.intel.com>>

Stop using the 'TRUE' define. This ultimately gets defined by
acpi/actypes.h that gets included here via a convoluted chain of
other headers. drm_crtc.h is part of that chain, and I'm trying
to eliminate all unnecessary includes from it to avoid pointless
rebuilds.

v2: Split out from the bigger patch

Cc: Zack Rusin <zackr at vmware.com<mailto:zackr at vmware.com>>
Cc: VMware Graphics Reviewers <linux-graphics-maintainer at vmware.com<mailto:linux-graphics-maintainer at vmware.com>>
Acked-by: Sam Ravnborg <sam at ravnborg.org<mailto:sam at ravnborg.org>>
Acked-by: Jani Nikula <jani.nikula at intel.com<mailto:jani.nikula at intel.com>>
Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com<mailto:ville.syrjala at linux.intel.com>>
---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 693028c31b6b..ff2f735bbe7a 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
@@ -252,7 +252,7 @@ static void vmw_cursor_update_position(struct vmw_private *dev_priv,
vmw_write(dev_priv, SVGA_REG_CURSOR4_Y, y);
vmw_write(dev_priv, SVGA_REG_CURSOR4_SCREEN_ID, SVGA3D_INVALID_ID);
vmw_write(dev_priv, SVGA_REG_CURSOR4_ON, svga_cursor_on);
- vmw_write(dev_priv, SVGA_REG_CURSOR4_SUBMIT, TRUE);
+ vmw_write(dev_priv, SVGA_REG_CURSOR4_SUBMIT, 1);
} else if (vmw_is_cursor_bypass3_enabled(dev_priv)) {
vmw_fifo_mem_write(dev_priv, SVGA_FIFO_CURSOR_ON, svga_cursor_on);
vmw_fifo_mem_write(dev_priv, SVGA_FIFO_CURSOR_X, x);

Hi, Ville.

Sorry for the delay. Looks great. In case you haven’t pushed it to drm-misc-next yet:

Reviewed-by: Zack Rusin <zackr at vmware.com<mailto:zackr at vmware.com>>

z
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20220705/9904e6c5/attachment.htm>