[PATCH V3 09/12] drm/bridge: tc358767: Move bridge ops setup into tc_probe_edp_bridge_endpoint()
Lucas Stach
l.stach at pengutronix.de
Mon Mar 28 20:16:58 UTC 2022
Am Donnerstag, dem 24.02.2022 um 20:58 +0100 schrieb Marek Vasut:
> The bridge ops are specific to the bridge configuration, move them
> into tc_probe_edp_bridge_endpoint() to permit cleaner addition of
> DSI-to-DPI mode. No functional change.
>
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Jonas Karlman <jonas at kwiboo.se>
> Cc: Laurent Pinchart <Laurent.pinchart at ideasonboard.com>
> Cc: Maxime Ripard <maxime at cerno.tech>
> Cc: Neil Armstrong <narmstrong at baylibre.com>
> Cc: Sam Ravnborg <sam at ravnborg.org>
Reviewed-by: Lucas Stach <l.stach at pengutronix.de>
> ---
> V2: - New patch
> V3: - No change
> ---
> drivers/gpu/drm/bridge/tc358767.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index b4ae4dd5b89aa..07da6142d5cf2 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -1676,6 +1676,11 @@ static int tc_probe_edp_bridge_endpoint(struct tc_data *tc)
> tc->bridge.type = DRM_MODE_CONNECTOR_DisplayPort;
> }
>
> + tc->bridge.funcs = &tc_edp_bridge_funcs;
> + if (tc->hpd_pin >= 0)
> + tc->bridge.ops |= DRM_BRIDGE_OP_DETECT;
> + tc->bridge.ops |= DRM_BRIDGE_OP_EDID;
> +
> return ret;
> }
>
> @@ -1757,11 +1762,6 @@ static int tc_probe(struct i2c_client *client, const struct i2c_device_id *id)
> if (ret)
> return ret;
>
> - tc->bridge.funcs = &tc_edp_bridge_funcs;
> - if (tc->hpd_pin >= 0)
> - tc->bridge.ops |= DRM_BRIDGE_OP_DETECT;
> - tc->bridge.ops |= DRM_BRIDGE_OP_EDID;
> -
> tc->bridge.of_node = dev->of_node;
> drm_bridge_add(&tc->bridge);
>
More information about the dri-devel
mailing list