[PATCH V3 12/12] drm/bridge: tc358767: Add DSI-to-DPI mode support
Lucas Stach
l.stach at pengutronix.de
Mon Mar 28 20:22:18 UTC 2022
Am Donnerstag, dem 24.02.2022 um 20:58 +0100 schrieb Marek Vasut:
> The TC358767/TC358867/TC9595 are all capable of operating in multiple
> modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Add support for the
> DSI-to-DPI mode.
>
> This requires skipping most of the (e)DP initialization code, which is
> currently a large part of this driver, hence it is better to have far
> simpler separate tc_dpi_bridge_funcs and their implementation.
>
> The configuration of DPI output is also much simpler. The configuration
> of the DSI input is rather similar to the other TC bridge chips.
>
> The Pixel PLL in DPI output mode does not have the 65..150 MHz limitation
> imposed on the (e)DP output mode, so this limitation is skipped to permit
> operating panels with far slower pixel clock, even below 9 MHz. This mode
> of operation of the PLL is valid and tested.
>
> The detection of bridge mode is now added into tc_probe_bridge_mode(),
> where in case a DPI panel is found on port at 1 endpoint at 1, the mode is
> assumed to be DSI-to-DPI. If (e)DP is detected on port at 2, the mode is
> assumed to be DPI-to-(e)DP.
>
> The DSI-to-(e)DP mode is not supported due to lack of proper hardware,
> but this would be some sort of mix between the two aforementioned modes.
>
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Jonas Karlman <jonas at kwiboo.se>
> Cc: Laurent Pinchart <Laurent.pinchart at ideasonboard.com>
> Cc: Maxime Ripard <maxime at cerno.tech>
> Cc: Neil Armstrong <narmstrong at baylibre.com>
> Cc: Sam Ravnborg <sam at ravnborg.org>
This fails to link without CONFIG_DRM_MIPI_DSI. As this is not a
visible symbol it needs to be selected from the TC358767 Kconfig entry.
One more nit below, other than that:
Reviewed-by: Lucas Stach <l.stach at pengutronix.de>
> ---
> V2: - Rebase on next-20220217 and new patches in this series
> V3: - Drop edp from tc_edp_common_atomic_check,
> s@\<tc_edp_common_atomic_check\>@tc_common_atomic_check at g
> - Limit Pixel PLL output to 0-100 MHz for DPI and 150-650 MHz for eDP
> - Drop VID_EN write from tc_dpi_stream_disable()
> - Reduce PLL stabilization delay to 120..150us in tc_dpi_stream_enable()
> - Call drm_bridge_remove() in case tc_mipi_dsi_host_attach() fails
> - Check of_property_count_u32_elems() return code as int instead of u8
> - Enable DP0/DP1 PLL for DSI-to-DPI mode too, they clock the internal
> framebuffer and it is too slow if those PLLs are in bypass
> ---
> drivers/gpu/drm/bridge/tc358767.c | 364 +++++++++++++++++++++++++++++-
> 1 file changed, 353 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index b1b02de4bbb3d..16c15aaab1b47 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -1,6 +1,12 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> - * tc358767 eDP bridge driver
> + * TC358767/TC358867/TC9595 DSI/DPI-to-DPI/(e)DP bridge driver
> + *
> + * The TC358767/TC358867/TC9595 can operate in multiple modes.
> + * The following modes are supported:
> + * DPI->(e)DP -- supported
> + * DSI->DPI .... supported
> + * DSI->(e)DP .. NOT supported
> *
> * Copyright (C) 2016 CogentEmbedded Inc
> * Author: Andrey Gusakov <andrey.gusakov at cogentembedded.com>
> @@ -29,6 +35,7 @@
> #include <drm/drm_bridge.h>
> #include <drm/dp/drm_dp_helper.h>
> #include <drm/drm_edid.h>
> +#include <drm/drm_mipi_dsi.h>
> #include <drm/drm_of.h>
> #include <drm/drm_panel.h>
> #include <drm/drm_print.h>
> @@ -36,7 +43,35 @@
>
> /* Registers */
>
> -/* Display Parallel Interface */
> +/* PPI layer registers */
> +#define PPI_STARTPPI 0x0104 /* START control bit */
> +#define PPI_LPTXTIMECNT 0x0114 /* LPTX timing signal */
> +#define LPX_PERIOD 3
> +#define PPI_LANEENABLE 0x0134
> +#define PPI_TX_RX_TA 0x013c
> +#define TTA_GET 0x40000
> +#define TTA_SURE 6
> +#define PPI_D0S_ATMR 0x0144
> +#define PPI_D1S_ATMR 0x0148
> +#define PPI_D0S_CLRSIPOCOUNT 0x0164 /* Assertion timer for Lane 0 */
> +#define PPI_D1S_CLRSIPOCOUNT 0x0168 /* Assertion timer for Lane 1 */
> +#define PPI_D2S_CLRSIPOCOUNT 0x016c /* Assertion timer for Lane 2 */
> +#define PPI_D3S_CLRSIPOCOUNT 0x0170 /* Assertion timer for Lane 3 */
> +#define PPI_START_FUNCTION BIT(0)
> +
> +/* DSI layer registers */
> +#define DSI_STARTDSI 0x0204 /* START control bit of DSI-TX */
> +#define DSI_LANEENABLE 0x0210 /* Enables each lane */
> +#define DSI_RX_START BIT(0)
> +
> +/* Lane enable PPI and DSI register bits */
> +#define LANEENABLE_CLEN BIT(0)
> +#define LANEENABLE_L0EN BIT(1)
> +#define LANEENABLE_L1EN BIT(2)
> +#define LANEENABLE_L2EN BIT(1)
> +#define LANEENABLE_L3EN BIT(2)
> +
> +/* Display Parallel Input Interface */
> #define DPIPXLFMT 0x0440
> #define VS_POL_ACTIVE_LOW (1 << 10)
> #define HS_POL_ACTIVE_LOW (1 << 9)
> @@ -48,6 +83,14 @@
> #define DPI_BPP_RGB666 (1 << 0)
> #define DPI_BPP_RGB565 (2 << 0)
>
> +/* Display Parallel Output Interface */
> +#define POCTRL 0x0448
> +#define POCTRL_S2P BIT(7)
> +#define POCTRL_PCLK_POL BIT(3)
> +#define POCTRL_VS_POL BIT(2)
> +#define POCTRL_HS_POL BIT(1)
> +#define POCTRL_DE_POL BIT(0)
> +
> /* Video Path */
> #define VPCTRL0 0x0450
> #define VSDELAY GENMASK(31, 20)
> @@ -247,6 +290,9 @@ struct tc_data {
> struct drm_bridge *panel_bridge;
> struct drm_connector connector;
>
> + struct mipi_dsi_device *dsi;
> + u8 dsi_lanes;
> +
> /* link settings */
> struct tc_edp_link link;
>
> @@ -469,10 +515,24 @@ static int tc_pxl_pll_en(struct tc_data *tc, u32 refclk, u32 pixelclock)
> int mul, best_mul = 1;
> int delta, best_delta;
> int ext_div[] = {1, 2, 3, 5, 7};
> + int clk_min, clk_max;
> int best_pixelclock = 0;
> int vco_hi = 0;
> u32 pxl_pllparam;
>
> + /*
> + * refclk * mul / (ext_pre_div * pre_div) should be in range:
> + * - DPI ..... 0 to 100 MHz
> + * - (e)DP ... 150 to 650 MHz
> + */
> + if (tc->bridge.type == DRM_MODE_CONNECTOR_DPI) {
> + clk_min = 0;
> + clk_max = 100000000;
> + } else {
> + clk_min = 150000000;
> + clk_max = 650000000;
> + }
> +
> dev_dbg(tc->dev, "PLL: requested %d pixelclock, ref %d\n", pixelclock,
> refclk);
> best_delta = pixelclock;
> @@ -499,11 +559,7 @@ static int tc_pxl_pll_en(struct tc_data *tc, u32 refclk, u32 pixelclock)
> continue;
>
> clk = (refclk / ext_div[i_pre] / div) * mul;
> - /*
> - * refclk * mul / (ext_pre_div * pre_div)
> - * should be in the 150 to 650 MHz range
> - */
> - if ((clk > 650000000) || (clk < 150000000))
> + if ((clk > clk_max) || (clk < clk_min))
> continue;
>
> clk = clk / ext_div[i_post];
> @@ -820,6 +876,20 @@ static int tc_set_common_video_mode(struct tc_data *tc,
> return ret;
> }
>
> +static int tc_set_dpi_video_mode(struct tc_data *tc,
> + const struct drm_display_mode *mode)
> +{
> + u32 value = POCTRL_S2P;
> +
> + if (tc->mode.flags & DRM_MODE_FLAG_NHSYNC)
> + value |= POCTRL_HS_POL;
> +
> + if (tc->mode.flags & DRM_MODE_FLAG_NVSYNC)
> + value |= POCTRL_VS_POL;
> +
> + return regmap_write(tc->regmap, POCTRL, value);
> +}
> +
> static int tc_set_edp_video_mode(struct tc_data *tc,
> const struct drm_display_mode *mode)
> {
> @@ -1192,6 +1262,85 @@ static int tc_main_link_disable(struct tc_data *tc)
> return regmap_write(tc->regmap, DP0CTL, 0);
> }
>
> +static int tc_dpi_stream_enable(struct tc_data *tc)
> +{
> + int ret;
> + u32 value;
> +
> + dev_dbg(tc->dev, "enable video stream\n");
> +
> + /* Setup PLL */
> + ret = tc_set_syspllparam(tc);
> + if (ret)
> + return ret;
> +
> + /*
> + * Initially PLLs are in bypass. Force PLL parameter update,
> + * disable PLL bypass, enable PLL
> + */
> + ret = tc_pllupdate(tc, DP0_PLLCTRL);
> + if (ret)
> + return ret;
> +
> + ret = tc_pllupdate(tc, DP1_PLLCTRL);
> + if (ret)
> + return ret;
> +
> + /* Pixel PLL must always be enabled for DPI mode */
> + ret = tc_pxl_pll_en(tc, clk_get_rate(tc->refclk),
> + 1000 * tc->mode.clock);
> + if (ret)
> + return ret;
> +
> + regmap_write(tc->regmap, PPI_D0S_CLRSIPOCOUNT, 3);
> + regmap_write(tc->regmap, PPI_D1S_CLRSIPOCOUNT, 3);
> + regmap_write(tc->regmap, PPI_D2S_CLRSIPOCOUNT, 3);
> + regmap_write(tc->regmap, PPI_D3S_CLRSIPOCOUNT, 3);
> + regmap_write(tc->regmap, PPI_D0S_ATMR, 0);
> + regmap_write(tc->regmap, PPI_D1S_ATMR, 0);
> + regmap_write(tc->regmap, PPI_TX_RX_TA, TTA_GET | TTA_SURE);
> + regmap_write(tc->regmap, PPI_LPTXTIMECNT, LPX_PERIOD);
> +
> + value = ((LANEENABLE_L0EN << tc->dsi_lanes) - LANEENABLE_L0EN) |
> + LANEENABLE_CLEN;
> + regmap_write(tc->regmap, PPI_LANEENABLE, value);
> + regmap_write(tc->regmap, DSI_LANEENABLE, value);
> +
> + ret = tc_set_common_video_mode(tc, &tc->mode);
> + if (ret)
> + return ret;
> +
> + ret = tc_set_dpi_video_mode(tc, &tc->mode);
> + if (ret)
> + return ret;
> +
> + /* Set input interface */
> + value = DP0_AUDSRC_NO_INPUT;
> + if (tc_test_pattern)
> + value |= DP0_VIDSRC_COLOR_BAR;
> + else
> + value |= DP0_VIDSRC_DSI_RX;
> + ret = regmap_write(tc->regmap, SYSCTRL, value);
> + if (ret)
> + return ret;
> +
> + usleep_range(120, 150);
> +
> + regmap_write(tc->regmap, PPI_STARTPPI, PPI_START_FUNCTION);
> + regmap_write(tc->regmap, DSI_STARTDSI, DSI_RX_START);
> +
> + return 0;
> +}
> +
> +static int tc_dpi_stream_disable(struct tc_data *tc)
> +{
> + dev_dbg(tc->dev, "disable video stream\n");
> +
> + tc_pxl_pll_dis(tc);
> +
> + return 0;
> +}
> +
> static int tc_edp_stream_enable(struct tc_data *tc)
> {
> int ret;
> @@ -1323,6 +1472,40 @@ static int tc_hardware_init(struct tc_data *tc)
> return 0;
> }
>
> +static void
> +tc_dpi_bridge_atomic_enable(struct drm_bridge *bridge,
> + struct drm_bridge_state *old_bridge_state)
> +
> +{
> + struct tc_data *tc = bridge_to_tc(bridge);
> + int ret;
> +
> + ret = tc_hardware_init(tc);
> + if (ret < 0) {
> + dev_err(tc->dev, "failed to initialize bridge: %d\n", ret);
> + return;
> + }
> +
> + ret = tc_dpi_stream_enable(tc);
> + if (ret < 0) {
> + dev_err(tc->dev, "main link stream start error: %d\n", ret);
> + tc_main_link_disable(tc);
> + return;
> + }
> +}
> +
> +static void
> +tc_dpi_bridge_atomic_disable(struct drm_bridge *bridge,
> + struct drm_bridge_state *old_bridge_state)
> +{
> + struct tc_data *tc = bridge_to_tc(bridge);
> + int ret;
> +
> + ret = tc_dpi_stream_disable(tc);
> + if (ret < 0)
> + dev_err(tc->dev, "main link stream stop error: %d\n", ret);
> +}
> +
> static void
> tc_edp_bridge_atomic_enable(struct drm_bridge *bridge,
> struct drm_bridge_state *old_bridge_state)
> @@ -1399,6 +1582,16 @@ static int tc_common_atomic_check(struct drm_bridge *bridge,
> return 0;
> }
>
> +static int tc_dpi_atomic_check(struct drm_bridge *bridge,
> + struct drm_bridge_state *bridge_state,
> + struct drm_crtc_state *crtc_state,
> + struct drm_connector_state *conn_state)
> +{
> + /* DSI->DPI interface clock limitation: upto 100 MHz */
> + return tc_common_atomic_check(bridge, bridge_state, crtc_state,
> + conn_state, 100000);
> +}
> +
> static int tc_edp_atomic_check(struct drm_bridge *bridge,
> struct drm_bridge_state *bridge_state,
> struct drm_crtc_state *crtc_state,
> @@ -1409,6 +1602,18 @@ static int tc_edp_atomic_check(struct drm_bridge *bridge,
> conn_state, 154000);
> }
>
> +static enum drm_mode_status
> +tc_dpi_mode_valid(struct drm_bridge *bridge,
> + const struct drm_display_info *info,
> + const struct drm_display_mode *mode)
> +{
> + /* DPI interface clock limitation: upto 100 MHz */
> + if (mode->clock > 100000)
> + return MODE_CLOCK_HIGH;
> +
> + return MODE_OK;
> +}
> +
> static enum drm_mode_status
> tc_edp_mode_valid(struct drm_bridge *bridge,
> const struct drm_display_info *info,
> @@ -1520,6 +1725,18 @@ static const struct drm_connector_funcs tc_connector_funcs = {
> .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
> };
>
> +static int tc_dpi_bridge_attach(struct drm_bridge *bridge,
> + enum drm_bridge_attach_flags flags)
> +{
> + struct tc_data *tc = bridge_to_tc(bridge);
> +
> + if (!tc->panel_bridge)
> + return 0;
> +
> + return drm_bridge_attach(tc->bridge.encoder, tc->panel_bridge,
> + &tc->bridge, flags);
> +}
> +
> static int tc_edp_bridge_attach(struct drm_bridge *bridge,
> enum drm_bridge_attach_flags flags)
> {
> @@ -1578,6 +1795,45 @@ static void tc_edp_bridge_detach(struct drm_bridge *bridge)
> drm_dp_aux_unregister(&bridge_to_tc(bridge)->aux);
> }
>
> +#define MAX_INPUT_SEL_FORMATS 1
> +
> +static u32 *
> +tc_dpi_atomic_get_input_bus_fmts(struct drm_bridge *bridge,
> + struct drm_bridge_state *bridge_state,
> + struct drm_crtc_state *crtc_state,
> + struct drm_connector_state *conn_state,
> + u32 output_fmt,
> + unsigned int *num_input_fmts)
> +{
> + u32 *input_fmts;
> +
> + *num_input_fmts = 0;
> +
> + input_fmts = kcalloc(MAX_INPUT_SEL_FORMATS, sizeof(*input_fmts),
> + GFP_KERNEL);
> + if (!input_fmts)
> + return NULL;
> +
> + /* This is the DSI-end bus format */
> + input_fmts[0] = MEDIA_BUS_FMT_RGB888_1X24;
> + *num_input_fmts = 1;
> +
> + return input_fmts;
> +}
> +
> +static const struct drm_bridge_funcs tc_dpi_bridge_funcs = {
> + .attach = tc_dpi_bridge_attach,
> + .mode_valid = tc_dpi_mode_valid,
> + .mode_set = tc_bridge_mode_set,
> + .atomic_check = tc_dpi_atomic_check,
> + .atomic_enable = tc_dpi_bridge_atomic_enable,
> + .atomic_disable = tc_dpi_bridge_atomic_disable,
> + .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
> + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
> + .atomic_reset = drm_atomic_helper_bridge_reset,
> + .atomic_get_input_bus_fmts = tc_dpi_atomic_get_input_bus_fmts,
> +};
> +
> static const struct drm_bridge_funcs tc_edp_bridge_funcs = {
> .attach = tc_edp_bridge_attach,
> .detach = tc_edp_bridge_detach,
> @@ -1678,6 +1934,82 @@ static irqreturn_t tc_irq_handler(int irq, void *arg)
> return IRQ_HANDLED;
> }
>
> +static int tc_mipi_dsi_host_attach(struct tc_data *tc)
> +{
> + struct device *dev = tc->dev;
> + struct device_node *host_node;
> + struct device_node *endpoint;
> + struct mipi_dsi_device *dsi;
> + struct mipi_dsi_host *host;
> + const struct mipi_dsi_device_info info = {
> + .type = "tc358767",
> + .channel = 0,
> + .node = NULL,
> + };
> + int dsi_lanes, ret;
> +
> + endpoint = of_graph_get_endpoint_by_regs(dev->of_node, 0, 0);
This port only has a single endpoint, so shouldn't the 3rd parameter be
-1?
> + dsi_lanes = of_property_count_u32_elems(endpoint, "data-lanes");
> + host_node = of_graph_get_remote_port_parent(endpoint);
> + host = of_find_mipi_dsi_host_by_node(host_node);
> + of_node_put(host_node);
> + of_node_put(endpoint);
> +
> + if (dsi_lanes < 0 || dsi_lanes > 4)
> + return -EINVAL;
> +
> + if (!host)
> + return -EPROBE_DEFER;
> +
> + dsi = mipi_dsi_device_register_full(host, &info);
> + if (IS_ERR(dsi))
> + return dev_err_probe(dev, PTR_ERR(dsi),
> + "failed to create dsi device\n");
> +
> + tc->dsi = dsi;
> +
> + tc->dsi_lanes = dsi_lanes;
> + dsi->lanes = tc->dsi_lanes;
> + dsi->format = MIPI_DSI_FMT_RGB888;
> + dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE;
> +
> + ret = mipi_dsi_attach(dsi);
> + if (ret < 0) {
> + dev_err(dev, "failed to attach dsi to host: %d\n", ret);
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> +static int tc_probe_dpi_bridge_endpoint(struct tc_data *tc)
> +{
> + struct device *dev = tc->dev;
> + struct drm_panel *panel;
> + int ret;
> +
> + /* port at 1 is the DPI input/output port */
> + ret = drm_of_find_panel_or_bridge(dev->of_node, 1, 0, &panel, NULL);
> + if (ret && ret != -ENODEV)
> + return ret;
> +
> + if (panel) {
> + struct drm_bridge *panel_bridge;
> +
> + panel_bridge = devm_drm_panel_bridge_add(dev, panel);
> + if (IS_ERR(panel_bridge))
> + return PTR_ERR(panel_bridge);
> +
> + tc->panel_bridge = panel_bridge;
> + tc->bridge.type = DRM_MODE_CONNECTOR_DPI;
> + tc->bridge.funcs = &tc_dpi_bridge_funcs;
> +
> + return 0;
> + }
> +
> + return ret;
> +}
> +
> static int tc_probe_edp_bridge_endpoint(struct tc_data *tc)
> {
> struct device *dev = tc->dev;
> @@ -1745,7 +2077,7 @@ static int tc_probe_bridge_endpoint(struct tc_data *tc)
> if (mode == mode_dpi_to_edp)
> return tc_probe_edp_bridge_endpoint(tc);
> else if (mode == mode_dsi_to_dpi)
> - dev_warn(dev, "The mode DSI-to-DPI is not supported!\n");
> + return tc_probe_dpi_bridge_endpoint(tc);
> else if (mode == mode_dsi_to_edp)
> dev_warn(dev, "The mode DSI-to-(e)DP is not supported!\n");
> else
> @@ -1828,15 +2160,25 @@ static int tc_probe(struct i2c_client *client, const struct i2c_device_id *id)
> tc->have_irq = true;
> }
>
> - ret = tc_aux_link_setup(tc);
> - if (ret)
> - return ret;
> + if (tc->bridge.type != DRM_MODE_CONNECTOR_DPI) { /* (e)DP output */
> + ret = tc_aux_link_setup(tc);
> + if (ret)
> + return ret;
> + }
>
> tc->bridge.of_node = dev->of_node;
> drm_bridge_add(&tc->bridge);
>
> i2c_set_clientdata(client, tc);
>
> + if (tc->bridge.type == DRM_MODE_CONNECTOR_DPI) { /* DPI output */
> + ret = tc_mipi_dsi_host_attach(tc);
> + if (ret) {
> + drm_bridge_remove(&tc->bridge);
> + return ret;
> + }
> + }
> +
> return 0;
> }
>
More information about the dri-devel
mailing list